From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D56BC10F14 for ; Sun, 21 Apr 2019 17:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CAB220833 for ; Sun, 21 Apr 2019 17:39:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="8A6SpRH9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728050AbfDURj4 (ORCPT ); Sun, 21 Apr 2019 13:39:56 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45953 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbfDURj4 (ORCPT ); Sun, 21 Apr 2019 13:39:56 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E607F20F24; Sun, 21 Apr 2019 13:31:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 21 Apr 2019 13:31:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wEROP8 7EX7vFODvLkRI+sX6gvO2Azb36WhV5V2GBSmo=; b=8A6SpRH9re4S/slNE5hC3A rzJxHpPUf9YpTbKzH8tmlslCqKMvyPDWGTVECq9CO1Z6EOa9g/QqzkoQToeFQ3tM ftPdiQd4ZePOj0MbF/0kp6BGpfXPJzQpA9NWteMUUv7a7+Bazol1NDyiQs6txs0z A7Usl3KoCEYSRkWo8evEOg7qONg99QAWUbgaaCiWJnukQMD0KxVzn06QXr1oCElt 4l5lEyqLSjha3E5YUBUEYRRlpoz1FYSXSjj1cXEH3EWVqSPFUjXTV09RwmH4Twf0 TfNgAfYvmIepkmJ0h5sasQPjkfSn7CivNcH+rSBVr4lpdxF1Twr0cbuYVTpW+SRg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeggdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucfkphepuddtle drieehrdeffedrudeftdenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehi ughoshgthhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (bzq-109-65-33-130.red.bezeqint.net [109.65.33.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CF14103C8; Sun, 21 Apr 2019 13:31:31 -0400 (EDT) Date: Sun, 21 Apr 2019 20:31:23 +0300 From: Ido Schimmel To: David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, David Ahern Subject: Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp Message-ID: <20190421173123.GA10601@splinter> References: <20190421154901.14202-1-dsahern@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190421154901.14202-1-dsahern@kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 21, 2019 at 08:49:01AM -0700, David Ahern wrote: > From: David Ahern > > After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use > ip6_route_info_create"), the gateway is no longer filled in for fib6_nh > structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check can > be dropped from the 'rt6_qualify_for_ecmp'. > > Further, RTF_DYNAMIC is only set in rt6_info instances, so it can be > removed from the check as well. > > This reduces rt6_qualify_for_ecmp and the mlxsw version to just checking > if the nexthop has a gateway which is the real indication of whether > entries can be coalesced into a multipath route. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel