From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=qyTB=SZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 53727C10F14
	for <netdev@archiver.kernel.org>; Tue, 23 Apr 2019 04:41:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 2971D2064A
	for <netdev@archiver.kernel.org>; Tue, 23 Apr 2019 04:41:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727885AbfDWEk6 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 23 Apr 2019 00:40:58 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:59346 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726135AbfDWEk6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 23 Apr 2019 00:40:58 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id AA008122CA807;
        Mon, 22 Apr 2019 21:40:57 -0700 (PDT)
Date:   Mon, 22 Apr 2019 21:40:57 -0700 (PDT)
Message-Id: <20190422.214057.869075562717360269.davem@davemloft.net>
To:     ard.biesheuvel@linaro.org
Cc:     ilias.apalodimas@linaro.org, netdev@vger.kernel.org,
        jaswinder.singh@linaro.org, masahisa.kojima@linaro.org
Subject: Re: [PATCH] net: socionext: replace napi_alloc_frag with the
 netdev variant on init
From:   David Miller <davem@davemloft.net>
In-Reply-To: <CAKv+Gu9fNBFrKBtbSYiEZeZ5MwzjjSmu1Fz+nAt6anr8Zb6r=g@mail.gmail.com>
References: <CAKv+Gu_Ajcty0S8=qyBhARNrA7rbAYfWuzTKXGX8wGUaJAve0g@mail.gmail.com>
        <20190418202451.GA31868@apalos>
        <CAKv+Gu9fNBFrKBtbSYiEZeZ5MwzjjSmu1Fz+nAt6anr8Zb6r=g@mail.gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Apr 2019 21:40:57 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Fri, 19 Apr 2019 08:46:40 +0200

> On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas
> <ilias.apalodimas@linaro.org> wrote:
>>
>> Hi Ard,
>> > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag
>> > >
>> >
>> > Why?
>> >
>> The netdev variant is usable on any context since it disables interrupts.
>> The napi variant of the call is supposed to be used under softirq context
>> only
>>
> 
> Helpful, thanks. In general, commit logs need to describe *why* you do
> something, since *what* you do is usually obvious from the patch
> itself, but why you do it isn't.
> 
> With the above clarification added:
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Just being clear, this patch needs to be reposted with the commit log extended
as requested.

Thank you.