From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andrei Vagin <avagin@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets
Date: Mon, 22 Apr 2019 10:38:13 +0200 [thread overview]
Message-ID: <20190422083813.jadafdr5mpwda2fe@salvia> (raw)
In-Reply-To: <20190417164944.1462-1-avagin@gmail.com>
On Wed, Apr 17, 2019 at 09:49:44AM -0700, Andrei Vagin wrote:
> It doesn't log a packet if sysctl_log_invalid isn't equal to protonum
> OR sysctl_log_invalid isn't equal to IPPROTO_RAW. This sentence is
> always true. I believe we need to replace OR to AND.
Applied, thanks.
next prev parent reply other threads:[~2019-04-22 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 16:49 [PATCH] netfilter: fix nf_l4proto_log_invalid to log invalid packets Andrei Vagin
2019-04-17 20:37 ` Florian Westphal
2019-04-22 8:38 ` Pablo Neira Ayuso [this message]
2019-04-30 6:38 ` Dexuan-Linux Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422083813.jadafdr5mpwda2fe@salvia \
--to=pablo@netfilter.org \
--cc=avagin@gmail.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox