From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E30C10F11 for ; Mon, 22 Apr 2019 19:23:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2804920896 for ; Mon, 22 Apr 2019 19:23:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="0geyQSq2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbfDVTXO (ORCPT ); Mon, 22 Apr 2019 15:23:14 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:42492 "EHLO mail-pf1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbfDVTXN (ORCPT ); Mon, 22 Apr 2019 15:23:13 -0400 Received: by mail-pf1-f179.google.com with SMTP id w25so6156766pfi.9 for ; Mon, 22 Apr 2019 12:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=suGFKpPVi/A+dGR/JE++3vR7mGJdPxF69eZjKs480Cw=; b=0geyQSq2/8aMhF6nwoyRKSjlH+UvBm5dGGMorqdvOshWS0Od6QP6tQPjkFTubsScUh B1AMysol264atQHEvZaPy/L+cOP9A9LK0FcyPq/Yngwloexf9By9asa/1apwhPNohzkB 8vaj/7kjoC7bmtjfxLMNpWW7u9gn9ngQdFVhI/AsCiCd+396W4dFMeRVS7GEk76virq0 J9PU2BdelV0A4TdAep6QH/8dCDYAmwdDdrH5RBJU0m+9I+VsPwPkwb0Ik5S6OSa0ddBG 5b1aNCg38J1/BbyD8hUK+7HCHfYbUUFuxLtRB64197JGgBmsB2dS7m2cm7Ww74qWRlMm +XnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=suGFKpPVi/A+dGR/JE++3vR7mGJdPxF69eZjKs480Cw=; b=hacoclmxpSn03aoxJ8Uv9Z71OcCI4neNxohMlZAoMyxD7/WH19PYc+J9EApV5HnRF6 vj45l4dqQSy/JFWax1OeCnErSb7dlUFAxSgeiNkmXShBPKiPngtPqxZJBGKnxnmpkQjE e/muer8tXnYayKob/dpCE1BBosz9+v5vU3+GYHzzVc1FvrTp2EucrW/t+08MwKFrMHy3 0WOLoHDg/yIHnq4+p6/6dxVspOcLHuzT/f9wxn/l0b9D6aMgJ4HKbi0DtDupJ5mwNJTT aYd5CRTfwtHQt0vpfaa1ztNlScCUrDWYhyE3cI8Cx5zX9Tb2v+g5ZKHyu2UxUG6qrrOw 4UVg== X-Gm-Message-State: APjAAAWLy503XQA1okpoFMdU6Oay3akuM5ROszmkbMpHwFQoBauK+OBf srJ4US0t1NAoGP+OcT8drLlpLg== X-Google-Smtp-Source: APXvYqxZnUhN4VX+7Y/yurr3BhyktX486vZCWASAqMHe9aAq6ACkw86HedaK6/aTgS4ZXH2C0cyl/g== X-Received: by 2002:aa7:8c56:: with SMTP id e22mr22146557pfd.155.1555960992953; Mon, 22 Apr 2019 12:23:12 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id x28sm14791855pgl.38.2019.04.22.12.23.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 12:23:12 -0700 (PDT) Date: Mon, 22 Apr 2019 12:23:02 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190422122302.14c8296f@cakuba.netronome.com> In-Reply-To: <20190420102922.6001-9-jiri@resnulli.us> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: > +static ssize_t del_device_store(struct bus_type *bus, const char *buf, > + size_t count) Please use the existing format of breaking multiline function declaration, if retype is longer than 3 chars it should be on a separate line: type name(arg, arg, .. arg, arg) Please fix everywhere.