netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Vakul Garg <vakul.garg@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: ipsec tunnel performance degrade
Date: Mon, 22 Apr 2019 19:45:37 +0200	[thread overview]
Message-ID: <20190422174537.mr52mqmmqdctm7qx@breakpoint.cc> (raw)
In-Reply-To: <VE1PR04MB6670D423693A3B5E79E937E78B220@VE1PR04MB6670.eurprd04.prod.outlook.com>

Vakul Garg <vakul.garg@nxp.com> wrote:
> Post kernel 4.9, I am experiencing more than 50% degrade in ipsec performance on my arm64 based systems (with onchip crypto accelerator).
> (We use only lts kernels). My understanding is that it is mainly due to xfrm flow cache removal in version 4.12.

Yes, likely.

> I am not sure whether any subsequent work could recover the lost performance.
> With kernel 4.19, I see that xfrm_state_find() is taking a lot of cpu (more than 15%).

Can you share details about the setup?

I.e., how many policies, states etc.?
Do you use xfrm interfaces?

> Further, perf show that a lot of atomic primitives such as __ll_sc___cmpxchg_case_mb_4(), 
> __ll_sc_atomic_sub_return() are being invoked. On 16 core system, they consume more than 30% of cpu.

Thats not good, perhaps we should look at pcpu refcounts for the xfrm
state structs.

  reply	other threads:[~2019-04-22 17:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 14:29 ipsec tunnel performance degrade Vakul Garg
2019-04-22 17:45 ` Florian Westphal [this message]
2019-04-23  2:36   ` Vakul Garg
2019-04-23  5:56     ` Florian Westphal
2019-04-23 15:04       ` Vakul Garg
2019-04-23 16:25         ` Florian Westphal
2019-04-23 17:27           ` David Miller
2019-04-24  7:32             ` Vakul Garg
2019-04-24 10:40           ` [RFC HACK] xfrm: make state refcounting percpu Florian Westphal
2019-04-24 11:38             ` Eric Dumazet
2019-05-03  6:07             ` Steffen Klassert
2019-05-03  6:13               ` Vakul Garg
2019-05-03  6:22                 ` Steffen Klassert
2019-05-03  6:34                   ` Vakul Garg
2019-05-03  6:46                     ` Steffen Klassert
2019-05-03  6:48                       ` Vakul Garg
2019-05-03 12:06               ` Eric Dumazet
2019-05-03 15:55                 ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190422174537.mr52mqmmqdctm7qx@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=vakul.garg@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).