From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0605C10F14 for ; Tue, 23 Apr 2019 06:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B6C820674 for ; Tue, 23 Apr 2019 06:29:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="AOip3pgy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725941AbfDWG31 (ORCPT ); Tue, 23 Apr 2019 02:29:27 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54073 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDWG31 (ORCPT ); Tue, 23 Apr 2019 02:29:27 -0400 Received: by mail-wm1-f65.google.com with SMTP id q16so17098344wmj.3 for ; Mon, 22 Apr 2019 23:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HbGJiLhIgV4Kyd/Qx6QY4pWzBWkIBRftDbRz1CbEELc=; b=AOip3pgyN9TuUz3GgIEGw6Ghn4Gg1Zm12C61VHWfl/amgAb2PfxOxhlbsiJ6yvYGat b1B6TX8J3bAxUVm6Wq8/OU4qKxsQuOeMr9e3bWHxi7RZ4Nlf628xtDo+clEjS9ADLc7Z 12PJ46ySZ9/9/dmIEfpSRHq7i/VDMUC5nPTyIpDuHmB5m4GO0ROjuGpLI6Vnr3WFJYBT J+arqIqrp2EpcaeL4cy4GrcD2PGjMsFkwqCPwh93QxJB36vPRK0uTCcVzbFz0Po3jMVp cdhlVgi+yq82aV/cgAPUiC0XR54cHOyXuIThDtLXP/QJZcu6lDD5WxphrzPRRmlyx1rx KgYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HbGJiLhIgV4Kyd/Qx6QY4pWzBWkIBRftDbRz1CbEELc=; b=gwzXivbO/4s0rzHKTxyw7PMH8XG6VXpnBR0ChANOwwRRbgoc/xWZDeKjsvCgEAxLEJ EWc896xGAtjf+2vvqudFFxUh/CrmucURmUY1aXZHW5lVuqEMVu/4r8YI4GV+7mBkNrT7 9JYXzvF7dbT0Pz4MwiTrQdQhW6zCJmnUdxtMoum/k89xFKQBYpRYQyn7EkCEn2EwRV7x VeJfgAcEpB+GQ8QzuDR/UL8G5SUkaY5ta3oZa8lI8Gj/eQ3TNFVqetVGsiNQBB8JK3In WPdLtUZwdvw8InbipMyDa9PLUymyE+iVxmD4lGkqLecMvIcf6rCD/1pmf2weR7JOfVBl CLHA== X-Gm-Message-State: APjAAAWv/XK/Kn/Uf7zUaNZBqs+Pcgs4GTqytcR6G4FCIGD58yNoZxEZ epNgCb4ENb+fGAgcUcoABCTJ1FnMFXI= X-Google-Smtp-Source: APXvYqxDE664uzXz63Pi5qyHWp0/uHLNZK8bEwMqESWZ+XkjWHPBDSzA7Dd8KsvQ81TcykJke8eIdg== X-Received: by 2002:a05:600c:21c3:: with SMTP id x3mr891515wmj.90.1556000965263; Mon, 22 Apr 2019 23:29:25 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id v184sm23472328wma.6.2019.04.22.23.29.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 23:29:24 -0700 (PDT) Date: Tue, 23 Apr 2019 08:29:23 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190423062923.GA2677@nanopsycho.orion> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> <20190422122302.14c8296f@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422122302.14c8296f@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Apr 22, 2019 at 09:23:02PM CEST, jakub.kicinski@netronome.com wrote: >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: >> +static ssize_t del_device_store(struct bus_type *bus, const char *buf, >> + size_t count) > >Please use the existing format of breaking multiline function >declaration, if retype is longer than 3 chars it should be on a >separate line: Where is it written down? First time I hear about such rule. > >type >name(arg, arg, .. > arg, arg) > >Please fix everywhere.