From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4402C10F03 for ; Tue, 23 Apr 2019 17:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82FB921850 for ; Tue, 23 Apr 2019 17:06:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="NDE4xObv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729277AbfDWRGu (ORCPT ); Tue, 23 Apr 2019 13:06:50 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:40635 "EHLO mail-qt1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728851AbfDWRGu (ORCPT ); Tue, 23 Apr 2019 13:06:50 -0400 Received: by mail-qt1-f176.google.com with SMTP id v7so3805044qti.7 for ; Tue, 23 Apr 2019 10:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=RZkH24m5/uoPjkCPRHU14UwkkMgMwP/PuNqDhmqqfb0=; b=NDE4xObviA/zWrHAinQWyW/uiKysLN6G8dwcRBqvhWXc1iDlTj4Hiwv1aZ30OEj8g7 kpBQOmmDlO5MvaLUpJIKcHVcKK1fRkjNWDD/87MN3tMMMeJ6dsF3v2hvy51J2l3KhdeA E5MgWvSYT6NUi0AZyYnB37Qc8feyJjVmIETmWuicDJfve0vyP7CIPWOUDvuQOtXJx5Ik zI7lb80YeKKASDbIjSROe65eLdgIfkxStLZPJcq+yMM71BRoh+uLNEm/+PgYLXie05CX FKhu9mW706WELGf0t6g6W/6zWoeQiLWhCvmGiKmatDfFcn+xUodgwsAr5uuknTgh77Q3 0NLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=RZkH24m5/uoPjkCPRHU14UwkkMgMwP/PuNqDhmqqfb0=; b=G8AIDigyfXeUMl0jUiI5nU2VaQjqjQoJwK37GKPXDuFbOIqYWFwMIVYYXQXn7LZQDN ooML4FITuYogplmWfJ7dALpU616Dvf7u/ZikYnQK7sRdYxSmmz+xEvyvg8QhInn27DMI 7gwZdidZWzqYUN3hgpS8VZPs9s/P4oVX2t6b8lNhGjrNAbRBBNNDPfCqkCzDVn+sGm/I 3bRc/GeYoqcDvhJLK9YPw+PHJP5uEGtJXpweREYdf2qJmPP0kyJhqS207mcFl8FvtjG9 cPU53ZesJzlOc5oJlUGaM4pj8tBp+PuqiWDF9o6PUXiObIsOLLr7LURTfBe924kFVJ8z v+Sg== X-Gm-Message-State: APjAAAUzpYKZD4JoN7Z0hXmbnT8aWW9SSn2MgIn6f6i9Qb9sRFNW1axH PggqkZD0rmVIbl2nQjyqgDL//QDh9Gw= X-Google-Smtp-Source: APXvYqyfqqwz2YvWgcaK8jlL4oPMn726bTjDEdv1yEocUssI0baUZd5Mt1CPliD8eMFkobumpIAdWg== X-Received: by 2002:a0c:b5d0:: with SMTP id o16mr21212565qvf.187.1556039209229; Tue, 23 Apr 2019 10:06:49 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y64sm9078187qkd.71.2019.04.23.10.06.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 10:06:49 -0700 (PDT) Date: Tue, 23 Apr 2019 10:06:42 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190423100642.634e1d25@cakuba.netronome.com> In-Reply-To: <20190423062923.GA2677@nanopsycho.orion> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> <20190422122302.14c8296f@cakuba.netronome.com> <20190423062923.GA2677@nanopsycho.orion> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 23 Apr 2019 08:29:23 +0200, Jiri Pirko wrote: > Mon, Apr 22, 2019 at 09:23:02PM CEST, jakub.kicinski@netronome.com wrote: > >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: > >> +static ssize_t del_device_store(struct bus_type *bus, const char *buf, > >> + size_t count) > > > >Please use the existing format of breaking multiline function > >declaration, if retype is longer than 3 chars it should be on a > >separate line: > > Where is it written down? First time I hear about such rule. That's sort of my rule, for code I maintain. The general rule of the thumb is follow the formatting of the existing code..