From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBB7C10F03 for ; Tue, 23 Apr 2019 17:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C03921850 for ; Tue, 23 Apr 2019 17:08:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="RR0y7EXu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729419AbfDWRIG (ORCPT ); Tue, 23 Apr 2019 13:08:06 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:34016 "EHLO mail-qk1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728902AbfDWRIF (ORCPT ); Tue, 23 Apr 2019 13:08:05 -0400 Received: by mail-qk1-f173.google.com with SMTP id n68so9058044qka.1 for ; Tue, 23 Apr 2019 10:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=zijB3o8dqN0B9D0MzbZN0NVpSnQI4pTDrNu4OIUkYtw=; b=RR0y7EXuYziKNkWm4BMoPKSzSWJS8nwXrFNVW9EJvy471XxKfc/Rc7Ims6G9GbdUnu LZIUA075XedLnzawFqfU7Y/orFt5iVtOTwMcprk5n21lXGMBdo/Yu24xQlB3tvZ2m232 ETR87sXIEmM60pnVmnRT9/VhfFOcjqSnm0IDR3fddAsX41xqBKOLy/vyq8Jl8jDUnqre HyPqqe+yfDjLgmHkGGnZHGeH5NoFhPwYn/Kjej/+HA813wvtInGP5gVwbjBDie7c6sdS tA1Kwa4Ud9JVi9c6HGf98vSfGrQhQZDh92108CaGRnJRyVKVfGiUv/NvfkveiS0L4BEo gXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=zijB3o8dqN0B9D0MzbZN0NVpSnQI4pTDrNu4OIUkYtw=; b=WpZQd4R4nMkUFvwh1JfQFIV23cP0ij6C6hOK8fbxwqj0PIXR95zAFmYOlY4vBWAFmW 4VBLKlzGrZlZgPG23sqYp53W+HFRILO7GUh3069ztqFY+KReWq1Vz303a8+RNF7PUnIN 1VtHfWJqIVrxL/dXxp2cI5JgLZNG4nfZ2HB+4YBigDmhO6ePXhUtETN1Shl5iRBnm4KC YysNW2hWJrk/SDJalaYTdSu8vPrFqHl7w3gVmPO+XMjRYkJnVbX9uW62f002eKSnlUdK C7EcDoXOOzG5jAsmf/FQTwMqkyG2fEWCSfNIiQw5NuyYXlrAZ/7LRvn6pfz+GY0DXVaN 93kg== X-Gm-Message-State: APjAAAX6ean33Np/LsY4kjW9pdRJFqYxYvrmw4PKIn01+QrO4eO3nHnK tYwO/eX9H+WBHsvvAO98gMOTKA== X-Google-Smtp-Source: APXvYqzLdvy+BZrbFYNwe3+a2Bcb3uLChUpWGsrEUWvgoiuIRkvYFTQ2+plYx97he8x6x523ahqloQ== X-Received: by 2002:a37:7183:: with SMTP id m125mr19962148qkc.119.1556039284978; Tue, 23 Apr 2019 10:08:04 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id m189sm8908516qkf.2.2019.04.23.10.08.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 10:08:04 -0700 (PDT) Date: Tue, 23 Apr 2019 10:08:00 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190423100800.1dfc1d98@cakuba.netronome.com> In-Reply-To: <20190423063108.GB2677@nanopsycho.orion> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> <20190422122338.3e1049a4@cakuba.netronome.com> <20190423063108.GB2677@nanopsycho.orion> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 23 Apr 2019 08:31:08 +0200, Jiri Pirko wrote: > Mon, Apr 22, 2019 at 09:23:38PM CEST, jakub.kicinski@netronome.com wrote: > >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: > >> - err = ida_alloc(&nsim_bus_dev_ids, GFP_KERNEL); > >> + err = ida_alloc_range(&nsim_bus_dev_ids, > >> + id == ~0 ? 0 : id, id, GFP_KERNEL); > > > >#define for ~0 ? > > Sure, but this is remove in patch 15. Is it necessary? Oh, I missed that.