From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A34C10F03 for ; Tue, 23 Apr 2019 19:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A94F121773 for ; Tue, 23 Apr 2019 19:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="0wMrKsdN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbfDWTJu (ORCPT ); Tue, 23 Apr 2019 15:09:50 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:39300 "EHLO mail-wm1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbfDWTJu (ORCPT ); Tue, 23 Apr 2019 15:09:50 -0400 Received: by mail-wm1-f53.google.com with SMTP id n25so1449253wmk.4 for ; Tue, 23 Apr 2019 12:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nZGtIFHOhH/Z/epK7jF0gmWu/K91XueZgijzRXEJfeg=; b=0wMrKsdN76dnSL+q3rx3Nk0x2dd2CBpVtTekTWnPJj4sVNLfZqpta6Nm+0yPSUiBtm cHB8fZG8s3cQk2yFFJ8sHONXSqe4CukPxbFmLM/lfO36vV2vNt8SKJGIFJULMhnt38Dh Q5h+Su541THcRQ19RhKw/2mJhhBhSaZVnB7Py5lflpSvkQHNnlEfG68AhvR6lBMoLUpO RX+pND69AKNIzIzBrdawPKaFtoasK8VW04ZSRTkj5HF2BdBbGmpezYP6bk+tR4xdDJnk Ptr0KZBWWvLuyhCg1XRzttZk7EmfmiY8F+oCd4vyshyy+PnOZVcfGGHwoQjBWWV6Zsi5 zpeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nZGtIFHOhH/Z/epK7jF0gmWu/K91XueZgijzRXEJfeg=; b=TE/7trIzOwfRx20Q8/bIBGDWGSOojAzkoemvUG3XwQwauF/wvrcfEvdOXlVAP37BtD u9TL+XNOA0uiMlVEOzE4v3CIPzurpCMqme4/G7rRlPEyZmC7ter33k8mM4QH5ke0gDyv DSVfkcfvOvHlln9pSfmot5k1ZfwswL9Ax5o7jUtY/eEYrxxfobbByGY5eEdl0yuYVjhe fdlvwu0idu/X7VN8qfWUmjI7kvls8HemOYx6UA0eWQuuwGaaa3ukAPyAMNpRhLnLaSHM Set6ZPilyo2HZaSaK2RF6HzJ+QuiiCTHOw+bxfqyFElnW21nvxiORKB1txVi/oXt2WP6 Rlmg== X-Gm-Message-State: APjAAAVw3ysbWm9sAoCt+8c4nmGCFO3K0DGhnfVnBhbnOqLkzfz6kWTj BI5nAAQcThgoYCQwYXzEo6EvWw== X-Google-Smtp-Source: APXvYqw9sj3FmLk43LW7oM81dAVinN/1BGLzxcbgapstC6OK/t3JdiC3liavCUNNz9GKQ+t5DUgEIg== X-Received: by 2002:a1c:cf83:: with SMTP id f125mr3268277wmg.96.1556046588444; Tue, 23 Apr 2019 12:09:48 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id s189sm31326058wmf.45.2019.04.23.12.09.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 12:09:47 -0700 (PDT) Date: Tue, 23 Apr 2019 21:09:47 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Message-ID: <20190423190947.GJ2677@nanopsycho.orion> References: <20190420102922.6001-1-jiri@resnulli.us> <20190420102922.6001-9-jiri@resnulli.us> <20190422122302.14c8296f@cakuba.netronome.com> <20190423062923.GA2677@nanopsycho.orion> <20190423100642.634e1d25@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423100642.634e1d25@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Apr 23, 2019 at 07:06:42PM CEST, jakub.kicinski@netronome.com wrote: >On Tue, 23 Apr 2019 08:29:23 +0200, Jiri Pirko wrote: >> Mon, Apr 22, 2019 at 09:23:02PM CEST, jakub.kicinski@netronome.com wrote: >> >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote: >> >> +static ssize_t del_device_store(struct bus_type *bus, const char *buf, >> >> + size_t count) >> > >> >Please use the existing format of breaking multiline function >> >declaration, if retype is longer than 3 chars it should be on a >> >separate line: >> >> Where is it written down? First time I hear about such rule. > >That's sort of my rule, for code I maintain. The general rule of >the thumb is follow the formatting of the existing code.. Okay. Will do :)