From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC8CC10F11 for ; Wed, 24 Apr 2019 13:14:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AE63218B0 for ; Wed, 24 Apr 2019 13:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="nzNjjFYL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730390AbfDXNOI (ORCPT ); Wed, 24 Apr 2019 09:14:08 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:35491 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730382AbfDXNOH (ORCPT ); Wed, 24 Apr 2019 09:14:07 -0400 Received: by mail-qt1-f195.google.com with SMTP id l17so974138qtp.2 for ; Wed, 24 Apr 2019 06:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P1C5c4IAYF5sG5ypkhdktl3shPqVF+gK3yd18onT4z0=; b=nzNjjFYL4MR0vne2uQJ4+Co03+QfWNDnUADUzK7CQjczJCJReMYOtgyAJAqAXmfZ3w 0pSk+G0x5ByAwy01YJqp4S5HBpdDDJU6iVOZi+HvnGEtvMEdV0wjdBBC70rWOInwuRu3 xAammwuCfJZw1qbpjJ5L5MtCpL+OwEkSenKj0p1hFGS9ZVkreNAsL13pLaX/BjyNHaJJ TX5W79ddDWGfgdG/8aRtICdjUTNsIpLRJcpEIbJIDGR09ULLvKtrMGclL3ZyE+6yOypx hd/lU/EbN5zQfue8kZSQd+rfAyot3rHcxbRN0G2I84NGW3AAGF9r5BVr8gKmlpEgHuS6 FD1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P1C5c4IAYF5sG5ypkhdktl3shPqVF+gK3yd18onT4z0=; b=X+xoGtGLV+o7BXS74plLmVDs4gHvQ25pOQSxa2M/qmvMTM07gU5ldN50WZSB+apjmJ jSB2Dd5flASJyYy80dyH2nANrKWtMT8pR7VuCu4/yPSmoRXQe4aLsci9qHoteQpoeuV+ 8wfAowAEapELsCb2Ws+XxVok0Dq7Ig96tOZVrO+lkcPPVEBCm3HQA+2ltsKViuxuNsC4 s12yIGsQOrUOM/9yRqmUZDWrEUH0Btyuwwy9kWNn5WJticFv2BkHoMWyJGUionOMFQVg MiVeAMa59LFuSJghtM4tyvXoShUiOVmO4bb+CrY+kl6f1IoLpD68I3CaeqsvZIE5zv1X b3jg== X-Gm-Message-State: APjAAAU3/6IVI3qZ9f/6loxG8oTK7a/XQKrNO2cD63yQPyvkYvX4t9qj IQQ/YxJKt/jLV46e4l15wljjAw== X-Google-Smtp-Source: APXvYqx+vBRYoKgoH/vxmJ65ZduNd4OYQrox/sZwyjH8iOXakRBM4bU+WHUXrahuTix/UEggXy3gog== X-Received: by 2002:a0c:ae50:: with SMTP id z16mr24752650qvc.153.1556111646697; Wed, 24 Apr 2019 06:14:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id x24sm11501618qtm.65.2019.04.24.06.14.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 06:14:05 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hJHiv-0001cJ-9O; Wed, 24 Apr 2019 10:14:05 -0300 Date: Wed, 24 Apr 2019 10:14:05 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , RDMA mailing list , Ariel Levkovich , Eli Cohen , Mark Bloch , Saeed Mahameed , linux-netdev Subject: Re: [PATCH rdma-next 4/8] IB/mlx5: Add steering SW ICM device memory type Message-ID: <20190424131405.GE16061@ziepe.ca> References: <20190331164450.23618-1-leon@kernel.org> <20190331164450.23618-5-leon@kernel.org> <20190424130440.GA5196@ziepe.ca> <20190424131222.GG27901@mtr-leonro.mtl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424131222.GG27901@mtr-leonro.mtl.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote: > On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote: > > On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote: > > > From: Ariel Levkovich > > > > > > This patch adds support for allocating, deallocating and registering > > > a new device memory type, STEERING_SW_ICM. > > > This memory can be allocated and used by a privileged user for direct > > > rule insertion and management of the device's steering tables. > > > > > > The type is provided by the user via the dedicated attribute in > > > the alloc_dm ioctl command. > > > > > > Signed-off-by: Ariel Levkovich > > > Reviewed-by: Eli Cohen > > > Reviewed-by: Mark Bloch > > > Signed-off-by: Leon Romanovsky > > > drivers/infiniband/hw/mlx5/Kconfig | 2 +- > > > drivers/infiniband/hw/mlx5/cmd.c | 127 +++++++++++++++++++- > > > drivers/infiniband/hw/mlx5/cmd.h | 6 +- > > > drivers/infiniband/hw/mlx5/main.c | 136 +++++++++++++++++++++- > > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 17 +++ > > > drivers/infiniband/hw/mlx5/mr.c | 7 ++ > > > include/uapi/rdma/mlx5_user_ioctl_verbs.h | 2 + > > > 7 files changed, 291 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig > > > index 8d651c05de62..347d457fcb2f 100644 > > > +++ b/drivers/infiniband/hw/mlx5/Kconfig > > > @@ -1,6 +1,6 @@ > > > config MLX5_INFINIBAND > > > tristate "Mellanox 5th generation network adapters (ConnectX series) support" > > > - depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE > > > + depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && PHYS_ADDR_T_64BIT > > > > Why do we need this? > > We are using phys_addr_t type and not u64 as an input to FW to emphasize > the caller interface, but it is different between 32 and 64 bits systems. > Such PHYS_ADDR_T_64BIT will ensure that phys_addr_t will be always 64 bits. ??? PHYS_ADDR_T should only ever be used to store a bus address - and if you are passing a bus address to/from FW then you 0 extend it on 32 bit, and range check on 64 bit. This is not a reason to force PHYS_ADDR_T_64BIT from a driver Jason