From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07F5C10F11 for ; Wed, 24 Apr 2019 20:49:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C25A218B0 for ; Wed, 24 Apr 2019 20:49:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="a/8EAQX2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732314AbfDXUtK (ORCPT ); Wed, 24 Apr 2019 16:49:10 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40564 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731341AbfDXUtJ (ORCPT ); Wed, 24 Apr 2019 16:49:09 -0400 Received: by mail-pf1-f194.google.com with SMTP id c207so9917511pfc.7 for ; Wed, 24 Apr 2019 13:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xhcYHlAB+wVNpmQQSxpaqKmqX7EvLGCkcexB0s2FgvM=; b=a/8EAQX2EBc8tYnJcGsAFu8Q+kNZxvTjt2task0Tg+ZwtsuFF1obdHziZog8MkQ1Hg i6oF98WzhxoAPn5Ub1NBQhVy7WFo7ax/Htuh+VkUaLQJI/BoPyq014MfZbUOJaimXZXD 1PADhgxUuGP+jLxxJlZSDxSuhkwWR/uZWoWlU8/XC2RUtOp00wbBBDfHag8leNPShjho wy2yUP7l0Y6UNaY0g6DxCJ7efbddspq3BJmGhhsd/J7jvHNpCFgN17MBeyceOZQVveBr Iec6NxwXKNyTNCwIwThB4rn02FimJ/Dd5FwWew1sXKp/vAY2a38xGxdDxg1ia8k6r+Uk Yd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xhcYHlAB+wVNpmQQSxpaqKmqX7EvLGCkcexB0s2FgvM=; b=dmxH0h1HpdpnRBFhHedS00z+KdGEaUlW7jIa+LqGbd5fpvSKn03uYe9hCo3oQtMbID DcHyt5o0AdVBdDXMaKJrzK4JkzK/pVfr+4teIVAxAeLtx6Bt8rNh+R2fR40Jr0NG3yyQ J/aOKU4CaLYrMMGTn7BSx8m965XcLN70JeQxPEAueVHcjYfuwCN2UhOZUWPTQ4GRyP1V 3o9EhesvYb8yfXEg0l10/fDJ6ohyqz/D63HQqZE1BPWr+kuyH4tFB3lG+7YQwyiko4qT 1Crd9VlcaUJzDY1LXNtOjGInFmD0+U6mh0KrUel+s2qUNt5zmbSMDBYZ66hZU7+PVwJg rmrg== X-Gm-Message-State: APjAAAW12CGSldblKc2x9JCgaHUw8DBoBNuwbyWnT2SUBv4i+4ZxPz4O /o2lwbKB/ri4WQq17za2E/beY686a1w= X-Google-Smtp-Source: APXvYqzdq4Otw4sCmgnaZPr2GFx/fZqiY/Wg/VUlhYwLvhptTuxikRcPsUOHP++T4RACgX2FSTDpzQ== X-Received: by 2002:a62:424b:: with SMTP id p72mr34586553pfa.167.1556138949095; Wed, 24 Apr 2019 13:49:09 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e8sm31880115pfc.47.2019.04.24.13.49.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 13:49:09 -0700 (PDT) Date: Wed, 24 Apr 2019 13:49:06 -0700 From: Stephen Hemminger To: Paolo Abeni Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next] tc: add support for plug qdisc Message-ID: <20190424134906.14311678@hermes.lan> In-Reply-To: <05c43d9415d196730ad382574a992497fd1d456d.1556121941.git.pabeni@redhat.com> References: <05c43d9415d196730ad382574a992497fd1d456d.1556121941.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 24 Apr 2019 18:29:39 +0200 Paolo Abeni wrote: > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) > +{ > + /* dummy implementation as sch_plug does not implement a dump op */ > + return 0; > +} > + All qdisc must dump their state in same form as the parse option.