From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FACC10F11 for ; Wed, 24 Apr 2019 15:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2933D20878 for ; Wed, 24 Apr 2019 15:53:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YO7nm4QP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731705AbfDXPxQ (ORCPT ); Wed, 24 Apr 2019 11:53:16 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43251 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730942AbfDXPxQ (ORCPT ); Wed, 24 Apr 2019 11:53:16 -0400 Received: by mail-qt1-f194.google.com with SMTP id g4so1451123qtq.10 for ; Wed, 24 Apr 2019 08:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1/43BQArgIDcP9Sj7eofm+ad3s3LetJpFBLIEBbCS78=; b=YO7nm4QPSpF6KZgFNfWYeyK/ZK5paDffRIhwBI4ZDVqUvqSSMwL1AAab411fn7d72N BgxXrl6tTBHBpOtvZ3iQNzkXXouY1V+MMb6BA+UU6ox2S554lh45OEliBgMu+rI2Z2iF v8bG0cnm9y3mpkA/MAoqg48HDSutCDR5Z9k3+qidVAhQQQ+Uha7DOrptoySUQM5jejh/ 4GdXjB3Gg57/cNeNaxOBfwgWr1K6br/cGYSypoFqM2ly1iF1f6BfBp0rQj9RSveDL2ex 070Mos2MQqSH0z0fXTr+4k+jx1UV6LgeJWfGvyz5L3b3aXAkU+Oo0BzVPef/HOSmCQVh Is5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1/43BQArgIDcP9Sj7eofm+ad3s3LetJpFBLIEBbCS78=; b=HwxOs/Wjibhq6sudqiWgxpcyfyKZDE50lhqZrW7JoHRqUieGO4aLBP+Fkr9UiTxSfb mpvLOWrrxKhq0bRGhhm+JTtyZTpxeIKczvy9xzUc/JiNIijwxo2uHfIyIIMqmnu3MR+0 4gUIGD5C57KWtfDFortbtvztO+hShe3RyohNfH9MTRdcSqVW6qP4ml+MmviQIhkQS8gs tBxU71TFD8zQselzY7itbVvdF13jyNJHSGYzYZ0Y+DZH3bRMhWD5z24bjrdPWPO6qDlh FXtZPaywp+yAqTPw0PfrYis4cldTfrr3gVw3/b54++PHbbgyYha/NyvEt8fidk9uZ+Rj fvQg== X-Gm-Message-State: APjAAAXbSMs+Suyiw8hJZBFpNxW/kny+EhbUF9ae+flFp3oSfMLUi8j0 rg/5XEahk/nWgjpnoZVp3KZXQg== X-Google-Smtp-Source: APXvYqxqJqqP0dxqCJeBw3UrD7mvILehD5k5rwiJB2hCw/J/080kFCCeKUy8OEiIYKk3BkjZ3IX5qg== X-Received: by 2002:ac8:1c17:: with SMTP id a23mr13143117qtk.133.1556121195010; Wed, 24 Apr 2019 08:53:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id o64sm9768619qkd.12.2019.04.24.08.53.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 08:53:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hJKCv-0001FZ-NQ; Wed, 24 Apr 2019 12:53:13 -0300 Date: Wed, 24 Apr 2019 12:53:13 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , RDMA mailing list , Ariel Levkovich , Eli Cohen , Mark Bloch , Saeed Mahameed , linux-netdev Subject: Re: [PATCH rdma-next 4/8] IB/mlx5: Add steering SW ICM device memory type Message-ID: <20190424155313.GI16061@ziepe.ca> References: <20190331164450.23618-1-leon@kernel.org> <20190331164450.23618-5-leon@kernel.org> <20190424130440.GA5196@ziepe.ca> <20190424131222.GG27901@mtr-leonro.mtl.com> <20190424131405.GE16061@ziepe.ca> <20190424132516.GH27901@mtr-leonro.mtl.com> <20190424133553.GF16061@ziepe.ca> <20190424134604.GI27901@mtr-leonro.mtl.com> <20190424134703.GG16061@ziepe.ca> <20190424154937.GJ27901@mtr-leonro.mtl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424154937.GJ27901@mtr-leonro.mtl.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 24, 2019 at 06:49:37PM +0300, Leon Romanovsky wrote: > On Wed, Apr 24, 2019 at 10:47:03AM -0300, Jason Gunthorpe wrote: > > On Wed, Apr 24, 2019 at 04:46:04PM +0300, Leon Romanovsky wrote: > > > On Wed, Apr 24, 2019 at 10:35:53AM -0300, Jason Gunthorpe wrote: > > > > On Wed, Apr 24, 2019 at 04:25:16PM +0300, Leon Romanovsky wrote: > > > > > On Wed, Apr 24, 2019 at 10:14:05AM -0300, Jason Gunthorpe wrote: > > > > > > On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote: > > > > > > > On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote: > > > > > > > > On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote: > > > > > > > > > From: Ariel Levkovich > > > > > > > > > > > > > > > > > > This patch adds support for allocating, deallocating and registering > > > > > > > > > a new device memory type, STEERING_SW_ICM. > > > > > > > > > This memory can be allocated and used by a privileged user for direct > > > > > > > > > rule insertion and management of the device's steering tables. > > > > > > > > > > > > > > > > > > The type is provided by the user via the dedicated attribute in > > > > > > > > > the alloc_dm ioctl command. > > > > > > > > > > > > > > > > > > Signed-off-by: Ariel Levkovich > > > > > > > > > Reviewed-by: Eli Cohen > > > > > > > > > Reviewed-by: Mark Bloch > > > > > > > > > Signed-off-by: Leon Romanovsky > > > > > > > > > drivers/infiniband/hw/mlx5/Kconfig | 2 +- > > > > > > > > > drivers/infiniband/hw/mlx5/cmd.c | 127 +++++++++++++++++++- > > > > > > > > > drivers/infiniband/hw/mlx5/cmd.h | 6 +- > > > > > > > > > drivers/infiniband/hw/mlx5/main.c | 136 +++++++++++++++++++++- > > > > > > > > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 17 +++ > > > > > > > > > drivers/infiniband/hw/mlx5/mr.c | 7 ++ > > > > > > > > > include/uapi/rdma/mlx5_user_ioctl_verbs.h | 2 + > > > > > > > > > 7 files changed, 291 insertions(+), 6 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig > > > > > > > > > index 8d651c05de62..347d457fcb2f 100644 > > > > > > > > > +++ b/drivers/infiniband/hw/mlx5/Kconfig > > > > > > > > > @@ -1,6 +1,6 @@ > > > > > > > > > config MLX5_INFINIBAND > > > > > > > > > tristate "Mellanox 5th generation network adapters (ConnectX series) support" > > > > > > > > > - depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE > > > > > > > > > + depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && PHYS_ADDR_T_64BIT > > > > > > > > > > > > > > > > Why do we need this? > > > > > > > > > > > > > > We are using phys_addr_t type and not u64 as an input to FW to emphasize > > > > > > > the caller interface, but it is different between 32 and 64 bits systems. > > > > > > > Such PHYS_ADDR_T_64BIT will ensure that phys_addr_t will be always 64 bits. > > > > > > > > > > > > ??? > > > > > > > > > > > > PHYS_ADDR_T should only ever be used to store a bus address - and if > > > > > > you are passing a bus address to/from FW then you 0 extend it on 32 > > > > > > bit, and range check on 64 bit. > > > > > > > > > > > > This is not a reason to force PHYS_ADDR_T_64BIT from a driver > > > > > > > > > > So how will I mark that we are forwarding physical address to FW? > > > > > > > > I don't know what this means.. phys_addr_t will transparently 0 extend > > > > to 64 bit which is the correct thing to do when passing a phys_addr_t > > > > to HW. > > > > > > It looks to me very similar to what I wanted: mark input as an address > > > and ensure that it is always u64 as our FW expects. > > > > So there is no reason for the kconfig hunk then > > The kconfig is needed to ensure that u64 value is truncated to be u32 on > 32bits systems. What? Jason