From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8563EC10F11 for ; Wed, 24 Apr 2019 19:03:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5672320835 for ; Wed, 24 Apr 2019 19:03:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="P1kUbaHh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388764AbfDXTDo (ORCPT ); Wed, 24 Apr 2019 15:03:44 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42564 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfDXTDn (ORCPT ); Wed, 24 Apr 2019 15:03:43 -0400 Received: by mail-qt1-f193.google.com with SMTP id p20so21587945qtc.9 for ; Wed, 24 Apr 2019 12:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UaAg5CqHExj7NlkPbUyFIoGHYUVt1S/1Qs9o/YzGTiU=; b=P1kUbaHhSuUxtxVYqePYjrmslU/CSPlqFuxoPHX5ANqippVF54UoHDRtaXPSMPpEZi MFtbm9dEtNNpmUijwS5OyqUhym8gRnCqaneBEEVH4efzHuafvIVqpHQju7dOkKLnX/mF +kpRoYGaqewn1BxXkcu5kxdvAEkFzqpTsbH8qqRpR3pybFkVl9sehUWevNb5x5o9M0s6 KmILrjnAErFk8KeV+evF3mkcDowZF+hYV0QqVfLPp6F/4+EcGnzxieUtlzRq44DdIQz/ F9Mqap2E/03r8h5oGFdgz8FsbuzXkInwnw4vrYS+3IaZ8ykBvauRF/2SntrWbr73oGQl ycIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UaAg5CqHExj7NlkPbUyFIoGHYUVt1S/1Qs9o/YzGTiU=; b=boyjnKOTOomBtJgxWt3m9mi0nfoOoU7WLIqyrHDCzYgd4p7Z7Fkm8AsuPOzqoTUX4i xIEKREIW+Jh1+c2g4QySisDzc6i3M/AD+4/z+b8OLt1bX4g7VhZez2EBHWm7xscOlo4j foR9j43eg1ZhkWo3UZO/r/dWTzBBcq0c6VJgq/JW3G9kj/b94AAt6SrlM6Sku2l2PkE1 ndqAG5iUkziP5P/175JVsa7SRPfwDQcnBSugXJeTyeGkgTEkK+DEvRF+0fZSbNJ7dZd2 m3DtvhR3wjSQLL2nSs3MyLMO8ydoStk5WwHty8jNF8spNdIi+zsOEGAFuORRXEybK9ap aM2w== X-Gm-Message-State: APjAAAURfvenZSv387KK0W+/Oc+yPwAtUOxQQndJkmSVh/857CakTqOS n9wg/0mEhThEymQ/HDz8XyjQzQ== X-Google-Smtp-Source: APXvYqwqoFTEkjnG4/OGRrgFHVGemLi3uhmWfvVRmDPfyWKJ1bxRdAaO1XEm6v09gOIYbfIV51FEJQ== X-Received: by 2002:ac8:2f08:: with SMTP id j8mr18024139qta.184.1556132622842; Wed, 24 Apr 2019 12:03:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id t188sm10466672qkf.81.2019.04.24.12.03.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 12:03:41 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hJNBF-00074J-6j; Wed, 24 Apr 2019 16:03:41 -0300 Date: Wed, 24 Apr 2019 16:03:41 -0300 From: Jason Gunthorpe To: Saeed Mahameed Cc: "leon@kernel.org" , Eli Cohen , "netdev@vger.kernel.org" , Ariel Levkovich , Leon Romanovsky , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , Mark Bloch Subject: Re: [PATCH rdma-next 0/8] User space steering Message-ID: <20190424190341.GM16061@ziepe.ca> References: <20190331164450.23618-1-leon@kernel.org> <20190424130714.GB5196@ziepe.ca> <4604e35554bb26c781bb685ae515fdfc06272d55.camel@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4604e35554bb26c781bb685ae515fdfc06272d55.camel@mellanox.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 24, 2019 at 04:40:54PM +0000, Saeed Mahameed wrote: > On Wed, 2019-04-24 at 10:07 -0300, Jason Gunthorpe wrote: > > On Sun, Mar 31, 2019 at 07:44:42PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > > From Ariel, > > > > > > This series of patches adds user space managed steering > > > infrastructure > > > to the mlx5_ib driver. > > > > > > User space managed steering requires the means to access a > > > dedicated > > > memory space that is used by the device to store the packet > > > steering > > > and header modification tables and rules in order to manage them > > > directly > > > without the device's firmware involvement. This dedicated memory is > > > part > > > of the ICM memory space. > > > > > > The changes are introducing the mlx5_ib API to allocate, deallocate > > > and > > > register this dedicated SW ICM memory via the existing device > > > memory API > > > using a private attribute which specifies the memory type. > > > > > > The allocated memory itself is not IO mapped and user can only > > > access it > > > using remote RDMA operations. > > > > > > In addition, the series exposed the ICM address of the receive > > > transport > > > interface (TIR) of Raw Packet and RSS QPs to user since they are > > > required > > > to properly create and insert steering rules that direct flows to > > > these QPs. > > > > > > Thanks > > > > > > Ariel Levkovich (8): > > > net/mlx5: Expose SW ICM related device memory capabilities > > > IB/mlx5: Support device memory type attribute > > > IB/mlx5: Warn on allocated MEMIC buffers during cleanup > > > IB/mlx5: Add steering SW ICM device memory type > > > IB/mlx5: Device resource control for privileged DEVX user > > > > This doesn't apply, it conflicts with patches in mlx5-next, please > > resent > > > > > net/mlx5: Expose TIR ICM address in command outbox > > > net/mlx5: Introduce new TIR creation core API > > > IB/mlx5: Expose TIR ICM address to user space > > > > it is a 3 patch series: > net/mlx5: Expose TIR ICM address in command outbox > net/mlx5: Introduce new TIR creation core API > net/mlx5: Expose SW ICM related device memory capabilities > > LGTM, I can apply them if you want, or do you want to wait for leon ? Fine by me Jason