From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: avoid unneeded MDIO reads in genphy_read_status
Date: Thu, 25 Apr 2019 00:41:41 +0200 [thread overview]
Message-ID: <20190424224141.GA23779@lunn.ch> (raw)
In-Reply-To: <92a0d681-33ea-feb7-bdf5-ff6fd9911ce1@gmail.com>
On Wed, Apr 24, 2019 at 09:49:30PM +0200, Heiner Kallweit wrote:
> Considering that in polling mode each link drop will be latched,
> settings can't have changed if link was up and is up.
Hi Heiner
What about the case of the PHY performing a downshift?
Could it be up, then finds a pair fails, so performs a downshift. Does
it always report link down and then up to the new speed? Or could it
just shift down? And so we want to read the new speed?
I suppose it could also perform an upshift? A broken pair comes back
to life, so it returns to the higher speed?
Andrew
next prev parent reply other threads:[~2019-04-24 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 19:49 [PATCH net-next] net: phy: avoid unneeded MDIO reads in genphy_read_status Heiner Kallweit
2019-04-24 22:41 ` Andrew Lunn [this message]
2019-04-25 5:02 ` Heiner Kallweit
2019-04-28 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424224141.GA23779@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).