From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=jfLS=S2=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 011BCC10F11
	for <netdev@archiver.kernel.org>; Wed, 24 Apr 2019 22:41:48 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B6458208E4
	for <netdev@archiver.kernel.org>; Wed, 24 Apr 2019 22:41:47 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="QdO9L4N8"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726730AbfDXWlq (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 24 Apr 2019 18:41:46 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:43353 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726546AbfDXWlq (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 24 Apr 2019 18:41:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=6oP19DRtuKvdCZBx7kdKnUL/R4UdSJUZI50FD/G48vA=; b=QdO9L4N8b+ZTcYhAeOJ/JGPBGZ
        YE6fmCquyT4Q8L5mY5xS76MhGwEb60ALXkiHMkhRXRwnzJkr2RC4/YkhVtqpt9J4AB2to/heytK+I
        yvyO24yN6rybcgt/YiI9UYDr/nA5meiqpT+ylciK1etY62Wu/ls/F/u9dNmrglN0mQJs=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hJQaD-0006Jb-DV; Thu, 25 Apr 2019 00:41:41 +0200
Date:   Thu, 25 Apr 2019 00:41:41 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: avoid unneeded MDIO reads in
 genphy_read_status
Message-ID: <20190424224141.GA23779@lunn.ch>
References: <92a0d681-33ea-feb7-bdf5-ff6fd9911ce1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <92a0d681-33ea-feb7-bdf5-ff6fd9911ce1@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, Apr 24, 2019 at 09:49:30PM +0200, Heiner Kallweit wrote:
> Considering that in polling mode each link drop will be latched,
> settings can't have changed if link was up and is up.

Hi Heiner

What about the case of the PHY performing a downshift?

Could it be up, then finds a pair fails, so performs a downshift. Does
it always report link down and then up to the new speed? Or could it
just shift down? And so we want to read the new speed?

I suppose it could also perform an upshift? A broken pair comes back
to life, so it returns to the higher speed?

   Andrew