netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, bpf@vger.kernel.org,
	davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net,
	jakub.kicinski@netronome.com, quentin.monnet@netronome.com,
	Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: support BPF_PROG_QUERY for BPF_FLOW_DISSECTOR attach_type
Date: Thu, 25 Apr 2019 02:48:24 +0800	[thread overview]
Message-ID: <201904250237.q9Slxr3I%lkp@intel.com> (raw)
In-Reply-To: <20190423232200.101627-1-sdf@google.com>

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-support-BPF_PROG_QUERY-for-BPF_FLOW_DISSECTOR-attach_type/20190424-235216
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: sparc64-allnoconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):

   In file included from include/net/net_namespace.h:37:0,
                    from include/linux/inet.h:46,
                    from include/linux/sunrpc/msg_prot.h:204,
                    from include/linux/sunrpc/auth.h:16,
                    from include/linux/nfs_fs.h:31,
                    from arch/sparc//kernel/sys_sparc32.c:25:
>> include/linux/skbuff.h:1268:12: error: 'skb_flow_dissector_prog_query' defined but not used [-Werror=unused-function]
    static int skb_flow_dissector_prog_query(const union bpf_attr *attr,
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/skb_flow_dissector_prog_query +1268 include/linux/skbuff.h

  1255	
  1256	void skb_flow_dissector_init(struct flow_dissector *flow_dissector,
  1257				     const struct flow_dissector_key *key,
  1258				     unsigned int key_count);
  1259	
  1260	#ifdef CONFIG_NET
  1261	int skb_flow_dissector_prog_query(const union bpf_attr *attr,
  1262					  union bpf_attr __user *uattr);
  1263	int skb_flow_dissector_bpf_prog_attach(const union bpf_attr *attr,
  1264					       struct bpf_prog *prog);
  1265	
  1266	int skb_flow_dissector_bpf_prog_detach(const union bpf_attr *attr);
  1267	#else
> 1268	static int skb_flow_dissector_prog_query(const union bpf_attr *attr,
  1269						 union bpf_attr __user *uattr)
  1270	{
  1271		return -EOPNOTSUPP;
  1272	}
  1273	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5232 bytes --]

      parent reply	other threads:[~2019-04-24 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 23:21 [PATCH bpf-next 1/2] bpf: support BPF_PROG_QUERY for BPF_FLOW_DISSECTOR attach_type Stanislav Fomichev
2019-04-23 23:22 ` [PATCH bpf-next 2/2] bpftool: show flow_dissector attachment status Stanislav Fomichev
2019-04-23 23:32   ` Jakub Kicinski
2019-04-24  0:13     ` Stanislav Fomichev
2019-04-24  8:12   ` Quentin Monnet
2019-04-24 15:42     ` Stanislav Fomichev
2019-04-23 23:28 ` [PATCH bpf-next 1/2] bpf: support BPF_PROG_QUERY for BPF_FLOW_DISSECTOR attach_type Jakub Kicinski
2019-04-24  0:12   ` Stanislav Fomichev
2019-04-24 18:48 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201904250237.q9Slxr3I%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=quentin.monnet@netronome.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).