Re: [patch net-next v4 00/16] netdevsim: implement proper device model

Jakub Kicinski
2019-04-25T22:11:24Z

On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Currently the model of netdevsim is a bit odd in multiple ways.
> 1) devlink instance is not in any way related with actual netdevsim
> netdevices. Instead, it is created per-namespace.
> 2) multi-port netdevsim device is done using "link" attribute.
> 3) netdevsim bus is there only to have something to bind the netdev to,
> it really does not act as a bus.
> 4) netdevsim instances are created by "ip link add" which is great for
> soft devices with no hw backend. The rtnl core allocates netdev and
> calls into driver holding rtnl mutex. For hw-backed devices, this
> flow is wrong as it breaks order in which things are done.
>
> This patchset adjust netdevsim to fix all above.

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>