From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307FEC43219 for ; Thu, 25 Apr 2019 22:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F3F3206BA for ; Thu, 25 Apr 2019 22:11:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1wxzU0iJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731457AbfDYWLW (ORCPT ); Thu, 25 Apr 2019 18:11:22 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45071 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfDYWLW (ORCPT ); Thu, 25 Apr 2019 18:11:22 -0400 Received: by mail-qt1-f196.google.com with SMTP id b3so1931088qtc.12 for ; Thu, 25 Apr 2019 15:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=rxs+K42/3Gp1rjKsOKATr0Az3Np28vNMZWTi54to+Z4=; b=1wxzU0iJ6PQB4dTJhqeBA9R5i0BIpVwfyQAiJKSzpUPeLkmG8K9EpTgPn0Hk2YmHgv jCV6vzwm19BqFdhzEMDH2A+iw72DslmjDQXZ3p0yLPcQKEGkiI5OOXtJ9zmaXdxdBwwy /oGAMySX+p2SvLEpLpqlGjxSj6JvOfAmaRaOequhdTXLiZhWG00TREsFM3n8VfFvDTwB thddCSry0HcNc2UlM/3diD3aAVwCqAdUg23ZBNXqfHorrTN5qCQQUki0s0Ov+2RisjmJ M/QXsogyFJGpPsDrejtO23q6w0P4Z2p5YSwr1u8Tu7AjuDOu5jFApzuplQqsTw9fND81 j+fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=rxs+K42/3Gp1rjKsOKATr0Az3Np28vNMZWTi54to+Z4=; b=Ba347Bwuw8/mK1tsEuf9LCncH8eeU5Vot+5O7I4Il0em1wffr0P9pcv1ork1Gwk+wI Dp5ZVHhUSppdR0QEoi+iYR24Ew9+QWQWgqYaJs/aVpnVKMeTyqBsE8PQqozAt74J1nhv E0+lZIYh+4r0L4tj7BUle+1bOvhcPoegBQbhHlszMmOixgEv38e/yrTJcd/PFLGLazXH JGCOk3wGhfpDeiZ7UV7npoNtHXYwnxp08DSzjqpJDnw3hYouUhp3YBqQH0v5VP4XiwLN YNY2VsIO5SZ4kQCtBSlkZ85tQklpq6v+xI/cRPm/6iRf6l9RW2nc5JS3s1cFxpTC/xrS MhnA== X-Gm-Message-State: APjAAAXYnehgZe7Yk5jR1gl4xoHLyGPZcPS4+0pyXBT7Vh/uyzqYsrF1 X87fW85CgZ5vOBUlexVrMhNxCw== X-Google-Smtp-Source: APXvYqzUCBU80Xub+Rlqytm3z4Br4iT27lv2/g8Rm1cHXYz8qdK0ZbuMtGX654bdFZAHTD/aefeJ9A== X-Received: by 2002:ac8:37b0:: with SMTP id d45mr23473766qtc.368.1556230281669; Thu, 25 Apr 2019 15:11:21 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id e204sm11927631qkb.0.2019.04.25.15.11.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 15:11:21 -0700 (PDT) Date: Thu, 25 Apr 2019 15:11:17 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v4 00/16] netdevsim: implement proper device model Message-ID: <20190425151117.5082bc01@cakuba.netronome.com> In-Reply-To: <20190425135956.3970-1-jiri@resnulli.us> References: <20190425135956.3970-1-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Currently the model of netdevsim is a bit odd in multiple ways. > 1) devlink instance is not in any way related with actual netdevsim > netdevices. Instead, it is created per-namespace. > 2) multi-port netdevsim device is done using "link" attribute. > 3) netdevsim bus is there only to have something to bind the netdev to, > it really does not act as a bus. > 4) netdevsim instances are created by "ip link add" which is great for > soft devices with no hw backend. The rtnl core allocates netdev and > calls into driver holding rtnl mutex. For hw-backed devices, this > flow is wrong as it breaks order in which things are done. > > This patchset adjust netdevsim to fix all above. Acked-by: Jakub Kicinski