From: Mauro Rodrigues <maurosr@linux.vnet.ibm.com>
To: Murilo Fossa Vicentini <muvic@linux.ibm.com>
Cc: netdev@vger.kernel.org, tlfalcon@linux.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs
Date: Thu, 25 Apr 2019 13:51:09 -0300 [thread overview]
Message-ID: <20190425165109.GA12859@kashyyyk> (raw)
In-Reply-To: <20190425140233.99658-1-muvic@linux.ibm.com>
On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote:
> The ibmvnic driver currently uses the same fixed name when using
> request_irq, this makes it hard to parse when multiple VNIC devices are
> available at the same time. This patch adds the unit_address as the device
> identification along with an id for each queue.
>
> The original idea was to use the interface name as an identifier, but it
> is not feasible given these requests happen at adapter probe, and at this
> point netdev is not yet registered so it doesn't have the proper name
> assigned to it.
>
> Signed-off-by: Murilo Fossa Vicentini <muvic@linux.ibm.com>
Reviewed-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
This is very useful, thanks!
next prev parent reply other threads:[~2019-04-25 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 14:02 [PATCH net-next] ibmvnic: Add device identification to requested IRQs Murilo Fossa Vicentini
2019-04-25 16:51 ` Mauro Rodrigues [this message]
2019-04-25 17:18 ` Thomas Falcon
2019-04-28 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425165109.GA12859@kashyyyk \
--to=maurosr@linux.vnet.ibm.com \
--cc=muvic@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox