From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628F6C43219 for ; Thu, 25 Apr 2019 18:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D76C1206C0 for ; Thu, 25 Apr 2019 18:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iaApaGFc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730438AbfDYSVb (ORCPT ); Thu, 25 Apr 2019 14:21:31 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44036 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729809AbfDYSVa (ORCPT ); Thu, 25 Apr 2019 14:21:30 -0400 Received: by mail-pl1-f193.google.com with SMTP id y12so183136plk.11 for ; Thu, 25 Apr 2019 11:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DbfVxgdfCkhec35GU1HQ4GzG8kpZ8WlM4OxO53B8PaE=; b=iaApaGFcj6uU2U94JYwH+aiYpAs7mH4qgTvb/UfwCTNP1OssqnPAGZHW7IpbqdtiYp PyIuw9vaPpUD6RIQXKUtWGkSMvCzm3i5yCj4lH+X4560EZv9zmEXdNBAESbJ9v6+aOSV X++1ZxWBxs4iDNmx5gM00p77NUpD85HuuGe1GibMkOsENpkcOtmd35qt73CJhLIM2Cxh a+YNZry3+A1b2YcezOlSUbKGZ40TC2qUo3zcSW0L78XJYGbf9QzXqwIe3rG3oTfp9RuT k/Xqvp8/Oqyzg8Z9HdPmDsNmRNrhpxw6FrYQDR5AVepA2k3Jr9F8F8rwF1ZGAqfF04q/ AXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DbfVxgdfCkhec35GU1HQ4GzG8kpZ8WlM4OxO53B8PaE=; b=Y1W+N9fChpmeHtKXeRR0pI20NKGm/vPfIaMkqXRqMIle+ujEGV/S2FAE7icsi0RL5O xEf1f9nfRgWRmBP4eIHN2DGDU0NZosyXg1hFKmyuVLpkvEyH+Sn7AZ1FJA8229R5msMr z1sl34bbr4txq7NaJRJb0Fu/68f3KsDf8gg5tH7+okQ4QdPgHijFkcsAUxHLrR2/jlob Bk6agmiOqP+vkhPQydxY4t5hAokClgc+jehssxH25PWyexZNS2/Yu7AxekBiPswBYj1l AwQxTe8xRJDOOKEvRIN/fwtLDWhS0fqRxvhMaVBEQVAwRrpql4EmPHBU1x/edvsQ2PXM PvSw== X-Gm-Message-State: APjAAAV8G4tVh/bEvNb/TZjwqKuULOMzHuRCzDmqDGM925meJf36s+7+ U5BPmNXFSnAjEJkBnu/D//uH6A== X-Google-Smtp-Source: APXvYqx49q90L/wWwW5GuHsq/Eb9SbYDthv2PbvdhVaz1WB1tjR5W5Iz+vYFKxKh8VhUnwu/NtNifA== X-Received: by 2002:a17:902:b617:: with SMTP id b23mr38726843pls.73.1556216488899; Thu, 25 Apr 2019 11:21:28 -0700 (PDT) Received: from google.com ([2620:15c:202:201:bc61:d85d:eb16:9036]) by smtp.gmail.com with ESMTPSA id a18sm12011087pfg.177.2019.04.25.11.21.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 11:21:26 -0700 (PDT) Date: Thu, 25 Apr 2019 11:21:21 -0700 From: Benson Leung To: Heiner Kallweit Cc: Benjamin Herrenschmidt , Michael Ellerman , Oded Gabbay , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Joerg Roedel , David Woodhouse , Realtek linux nic maintainers , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Benson Leung , Enric Balletbo i Serra , Stephen Rothwell , Paul Mackerras , open list , "open list:AMD KFD" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:AMD IOMMU (AMD-VI)" , "open list:8169 10/100/1000 GIGABIT ETHERNET DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:PCI SUBSYSTEM" Subject: Re: [PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id Message-ID: <20190425182121.GA175682@google.com> References: <2e1f9a57-6d08-d017-24da-3e6b97fa2449@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Heiner, On Wed, Apr 24, 2019 at 09:17:19PM +0200, Heiner Kallweit wrote: > Use new helper pci_dev_id() to simplify the code. >=20 > Signed-off-by: Heiner Kallweit Acked-By: Benson Leung > --- > drivers/platform/chrome/chromeos_laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform= /chrome/chromeos_laptop.c > index 24326eecd..7abbb6167 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -125,7 +125,7 @@ static bool chromeos_laptop_match_adapter_devid(struc= t device *dev, u32 devid) > return false; > =20 > pdev =3D to_pci_dev(dev); > - return devid =3D=3D PCI_DEVID(pdev->bus->number, pdev->devfn); > + return devid =3D=3D pci_dev_id(pdev); > } > =20 > static void chromeos_laptop_check_adapter(struct i2c_adapter *adapter) > --=20 > 2.21.0 >=20 >=20 --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlzB+qEACgkQHwn1ewov 5lip2g//eS1J0w28ODQxNNXn6vFg16ufHWY3pS3fpqOzY2iOnxmiL4V9a8qXXgs6 Nb7+tl1LTqFgN10TKr4KcYiPShVug0uz3SX9Gx6sI8d0C8Cy74QrQf4wQp48cg6I 0J0BgM0Icd6QdpdrNYZrcRmFJc7FY16i30SMAuINtfcnqgw4oU6hSG3qNXjqNrFG 2VUUjZHpvbAwWso0xToWjfK0TNPQXSslFKi+ROjvWlL+y0TGUBbcMbxviAp1H35X CuT5Ijknh8FdG+NaMFnGXf6JvzGORNgXlAon15XEbKDf25/K/JyyDh9nJuPesOwG MmYEiWj29dwg3/8rKvuWpuJVqWplC4x+ZCFvvEaDFeoxZuoLVc5QkVMRkupxwoA7 Ux1/Q9A7YS7OjOPhN2DikJIn2hEJnEyCBU2PdKEZToCUJ/C2gA+WqHyNXcflOldD PBJSisoYM4LcuV1hhhfXUU/n/BgVPbmYWfvyQpHEbDpnlnDxMb+LheCgDlBn9mAh QBD82gS5LcMo20071hVEqReV4zBzOc+S+h/4OxYW2HCNyn3qwztqYOge2oM/ezQ8 CV98H+KfIw+dYK8Vi40O9C05+NRkcAY/RaZzjQMyDJG2KxcO1mZhdhhbzCBRuS0o pj3CU8ScPFa+s0qe7xk/Pac8fR6hmcse8jaJKX7in5MDKQNQ2CY= =Oshd -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--