From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E612EC43219 for ; Fri, 26 Apr 2019 05:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF0BC20652 for ; Fri, 26 Apr 2019 05:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbfDZFwY (ORCPT ); Fri, 26 Apr 2019 01:52:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:58400 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbfDZFwY (ORCPT ); Fri, 26 Apr 2019 01:52:24 -0400 Received: from localhost (unknown [12.154.31.185]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D29D13ED74F0; Thu, 25 Apr 2019 22:52:23 -0700 (PDT) Date: Fri, 26 Apr 2019 01:52:20 -0400 (EDT) Message-Id: <20190426.015220.2082398991607902079.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: jiri@resnulli.us, netdev@vger.kernel.org, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next v4 00/16] netdevsim: implement proper device model From: David Miller In-Reply-To: <20190425151117.5082bc01@cakuba.netronome.com> References: <20190425135956.3970-1-jiri@resnulli.us> <20190425151117.5082bc01@cakuba.netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 25 Apr 2019 22:52:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Thu, 25 Apr 2019 15:11:17 -0700 > On Thu, 25 Apr 2019 15:59:40 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the model of netdevsim is a bit odd in multiple ways. >> 1) devlink instance is not in any way related with actual netdevsim >> netdevices. Instead, it is created per-namespace. >> 2) multi-port netdevsim device is done using "link" attribute. >> 3) netdevsim bus is there only to have something to bind the netdev to, >> it really does not act as a bus. >> 4) netdevsim instances are created by "ip link add" which is great for >> soft devices with no hw backend. The rtnl core allocates netdev and >> calls into driver holding rtnl mutex. For hw-backed devices, this >> flow is wrong as it breaks order in which things are done. >> >> This patchset adjust netdevsim to fix all above. > > Acked-by: Jakub Kicinski Series applied, thanks everyone.