From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wgvw=S4=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8A9C43219
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:16:54 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1EAB8206C1
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:16:53 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2WX/DHWQ"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726974AbfDZVQw (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 26 Apr 2019 17:16:52 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:46093 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726392AbfDZVQw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 26 Apr 2019 17:16:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=ozB+sS/9509uagx+2DJROOfHqg+XKnSf2sl4irspShM=; b=2WX/DHWQFTbfpb3X/FvExdsmz6
        aRm5loU0lJUg6aVOgvLCYzqnsXXpQagM44wszc3eXUXgTroEShVBQpBhv1+2B5R+tNU9dzaRbRitf
        si5Lz2KuqwusyoXGXGZfMW8F/FWuzZOT86lmcNQSQHOdITx8K2snPjJQ2elfelYpOPJ0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hK8DA-0005JO-Lx; Fri, 26 Apr 2019 23:16:48 +0200
Date:   Fri, 26 Apr 2019 23:16:48 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Nikita Danilov <Nikita.Danilov@aquantia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH v3 net-next 06/15] net: aquantia: link status irq handling
Message-ID: <20190426211648.GO4041@lunn.ch>
References: <cover.1556270198.git.igor.russkikh@aquantia.com>
 <e1124c9c8fe49976e637e5d633960a633d99efd7.1556270198.git.igor.russkikh@aquantia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e1124c9c8fe49976e637e5d633960a633d99efd7.1556270198.git.igor.russkikh@aquantia.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +		if (self->aq_nic_cfg.link_irq_vec) {
> +			int irqvec = pci_irq_vector(self->pdev,
> +						   self->aq_nic_cfg.link_irq_vec);
> +			err = request_threaded_irq(irqvec, NULL,
> +						   aq_linkstate_threaded_isr,
> +						   IRQF_SHARED,
> +						   self->ndev->name, self);

At some point you should consider using the devm_* API. It will make
your cleanup code simpler.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew