From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nikita Danilov <Nikita.Danilov@aquantia.com>,
Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex
Date: Fri, 26 Apr 2019 23:20:08 +0200 [thread overview]
Message-ID: <20190426212008.GR4041@lunn.ch> (raw)
In-Reply-To: <e35bd61c19190bb85fb06662f7d356cbc550aac8.1556270198.git.igor.russkikh@aquantia.com>
On Fri, Apr 26, 2019 at 09:48:02AM +0000, Igor Russkikh wrote:
> From: Nikita Danilov <ndanilov@aquantia.com>
>
> Some of FW operations could be invoked simultaneously,
> from f.e. ethtool context and from service service activity work.
> Here we introduce a fw mutex to secure and serialize access
> to FW logic.
>
> Signed-off-by: Nikita Danilov <ndanilov@aquantia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
I still think it would be a good idea to put in the low level code a
check that the mutex is actually held when talking to the firmware.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-04-26 21:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 9:47 [PATCH v3 net-next 00/15] net: atlantic: Aquantia driver updates 2019-04 Igor Russkikh
2019-04-26 9:47 ` [PATCH v3 net-next 01/15] net: aquantia: add infrastructure to readout chip temperature Igor Russkikh
2019-04-26 21:00 ` Andrew Lunn
2019-04-26 9:47 ` [PATCH v3 net-next 02/15] net: aquantia: implement hwmon api for " Igor Russkikh
2019-04-26 21:06 ` Andrew Lunn
2019-04-27 6:02 ` Igor Russkikh
2019-04-26 9:47 ` [PATCH v3 net-next 03/15] net: aquantia: add link interrupt fields Igor Russkikh
2019-04-26 21:07 ` Andrew Lunn
2019-04-26 9:47 ` [PATCH v3 net-next 04/15] net: aquantia: link interrupt handling function Igor Russkikh
2019-04-26 21:10 ` Andrew Lunn
2019-04-27 6:10 ` Igor Russkikh
2019-04-26 9:47 ` [PATCH v3 net-next 05/15] net: aquantia: create global service workqueue Igor Russkikh
2019-04-26 21:11 ` Andrew Lunn
2019-04-26 9:47 ` [PATCH v3 net-next 06/15] net: aquantia: link status irq handling Igor Russkikh
2019-04-26 21:16 ` Andrew Lunn
2019-04-26 9:47 ` [PATCH v3 net-next 07/15] net: aquantia: improve ifup link detection Igor Russkikh
2019-04-26 9:47 ` [PATCH v3 net-next 08/15] net: aquantia: use macros for better visibility Igor Russkikh
2019-04-26 21:17 ` Andrew Lunn
2019-04-26 9:48 ` [PATCH v3 net-next 09/15] net: aquantia: user correct MSI irq type Igor Russkikh
2019-04-26 21:18 ` Andrew Lunn
2019-04-26 9:48 ` [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex Igor Russkikh
2019-04-26 21:20 ` Andrew Lunn [this message]
2019-04-27 6:33 ` Igor Russkikh
2019-04-26 9:48 ` [PATCH v3 net-next 11/15] net: aquantia: extract timer cb into work job Igor Russkikh
2019-04-26 9:48 ` [PATCH v3 net-next 12/15] net: aquantia: fetch up to date statistics on ethtool request Igor Russkikh
2019-04-26 18:50 ` Jakub Kicinski
2019-04-26 9:48 ` [PATCH v3 net-next 13/15] net: aquantia: get total counters from DMA block Igor Russkikh
2019-04-26 9:48 ` [PATCH v3 net-next 14/15] net: aquantia: fixups on 64bit dma counters Igor Russkikh
2019-04-26 21:36 ` Andrew Lunn
2019-04-27 6:28 ` Igor Russkikh
2019-04-27 15:35 ` Andrew Lunn
2019-04-26 9:48 ` [PATCH v3 net-next 15/15] net: aquantia: remove outdated device ids Igor Russkikh
2019-04-26 21:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426212008.GR4041@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bogdanov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Nikita.Danilov@aquantia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).