From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wgvw=S4=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E2622C43218
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:20:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B4FD6206C1
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:20:12 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FrC/QZgt"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726888AbfDZVUL (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 26 Apr 2019 17:20:11 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:46110 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726134AbfDZVUL (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 26 Apr 2019 17:20:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=OY3F5Gj9QO9UZqx4rQwmu6F/35E9QfP1fr+CXeR8oF4=; b=FrC/QZgtVSlMc5LqBx5uRHazFl
        pKcOy0ky3CV0BeU1uJ1Y9FeF+paibCK15rQ0Syobh0tukRTcTTO0zrzviwL+9Xwxbdk8/dmHfcgHB
        jxLGpkE1QPMgH0GO0p6TUHWLk4t85yYRa+HbP6P5QwAKd+Hmz3fKu4Q/hlqxRsvz3Rxs=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hK8GO-0005Ok-LW; Fri, 26 Apr 2019 23:20:08 +0200
Date:   Fri, 26 Apr 2019 23:20:08 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Nikita Danilov <Nikita.Danilov@aquantia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex
Message-ID: <20190426212008.GR4041@lunn.ch>
References: <cover.1556270198.git.igor.russkikh@aquantia.com>
 <e35bd61c19190bb85fb06662f7d356cbc550aac8.1556270198.git.igor.russkikh@aquantia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e35bd61c19190bb85fb06662f7d356cbc550aac8.1556270198.git.igor.russkikh@aquantia.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Apr 26, 2019 at 09:48:02AM +0000, Igor Russkikh wrote:
> From: Nikita Danilov <ndanilov@aquantia.com>
> 
> Some of FW operations could be invoked simultaneously,
> from f.e. ethtool context and from service service activity work.
> Here we introduce a fw mutex to secure and serialize access
> to FW logic.
> 
> Signed-off-by: Nikita Danilov <ndanilov@aquantia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>

I still think it would be a good idea to put in the low level code a
check that the mutex is actually held when talking to the firmware.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew