From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wgvw=S4=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 65DC6C43218
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:36:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 2ED682084F
	for <netdev@archiver.kernel.org>; Fri, 26 Apr 2019 21:36:46 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="BWqnLuqd"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726842AbfDZVgp (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 26 Apr 2019 17:36:45 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:46130 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726246AbfDZVgo (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 26 Apr 2019 17:36:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=/PBi6ueO/gvzi3SatME67saDEO7grBr3HF+FyzYUh6Y=; b=BWqnLuqdGLQn6JQUYKWTa0tGgf
        XkfXsg4cP/1iXfzgbSbpv7Ox6wjwtsxDfQ6l27uNvUI0/A3FZmY+vII8n6ZwyRuQILHR46/DqAnfZ
        yqlQk6uPK3I8wVwK33ZEPfAQL2URdKyABAJJIY38a2WgVAmsB2G67MFutiuRWjujHOzo=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hK8WN-0005Yj-Eu; Fri, 26 Apr 2019 23:36:39 +0200
Date:   Fri, 26 Apr 2019 23:36:39 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Nikita Danilov <Nikita.Danilov@aquantia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH v3 net-next 14/15] net: aquantia: fixups on 64bit dma
 counters
Message-ID: <20190426213639.GS4041@lunn.ch>
References: <cover.1556270198.git.igor.russkikh@aquantia.com>
 <f8cadcde4a8a1d5b1a2568f21fe6fbff9db28c02.1556270198.git.igor.russkikh@aquantia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f8cadcde4a8a1d5b1a2568f21fe6fbff9db28c02.1556270198.git.igor.russkikh@aquantia.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +	self->curr_stats.dma_pkt_rc = hw_atl_stats_rx_dma_good_pkt_counterlsw_get(self) +
> +				      ((u64)hw_atl_stats_rx_dma_good_pkt_countermsw_get(self) << 32);

Don't you need to do something to avoid issue with overflow from lsw
into msw? I've often seen code get the msw, the lsw and then the msm
again. If the two msw reads are different, it repeats it all again.

       Andrew