From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B470C4321A for ; Sun, 28 Apr 2019 00:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D0E2208C2 for ; Sun, 28 Apr 2019 00:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726247AbfD1AUd (ORCPT ); Sat, 27 Apr 2019 20:20:33 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfD1AUd (ORCPT ); Sat, 27 Apr 2019 20:20:33 -0400 Received: from localhost (unknown [12.154.31.190]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6E7CF14D3AC9D; Sat, 27 Apr 2019 17:20:32 -0700 (PDT) Date: Sat, 27 Apr 2019 20:20:30 -0400 (EDT) Message-Id: <20190427.202030.2266541288652581591.davem@davemloft.net> To: muvic@linux.ibm.com Cc: netdev@vger.kernel.org, tlfalcon@linux.ibm.com, maurosr@linux.vnet.ibm.com Subject: Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs From: David Miller In-Reply-To: <20190425140233.99658-1-muvic@linux.ibm.com> References: <20190425140233.99658-1-muvic@linux.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 27 Apr 2019 17:20:32 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Murilo Fossa Vicentini Date: Thu, 25 Apr 2019 11:02:33 -0300 > The ibmvnic driver currently uses the same fixed name when using > request_irq, this makes it hard to parse when multiple VNIC devices are > available at the same time. This patch adds the unit_address as the device > identification along with an id for each queue. > > The original idea was to use the interface name as an identifier, but it > is not feasible given these requests happen at adapter probe, and at this > point netdev is not yet registered so it doesn't have the proper name > assigned to it. > > Signed-off-by: Murilo Fossa Vicentini Applied, thanks.