From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BC6C43218 for ; Sat, 27 Apr 2019 16:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B640B2087F for ; Sat, 27 Apr 2019 16:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NP4Xq1US" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbfD0Qjo (ORCPT ); Sat, 27 Apr 2019 12:39:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46676 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbfD0Qjn (ORCPT ); Sat, 27 Apr 2019 12:39:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3x96KLf+7WG5HZo66dPuyudWlNtB7m+kcjzsKB7rZzg=; b=NP4Xq1USCnJhhYgYDDYXEAfO7F FGgqIcxVfyzF/TNICY/nGs8WP7a4PxioELoSKoCFgpAu3TA2hS6u0jXIgcnYNXUS0c/DcMANKnWb3 WaCK+nEJcGW7H4R96huF6cNNCPFWroHi82Or7gh9W1yQdJIRu+R0A5bwWFXhP1+YNzSU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hKQMF-0002l5-3c; Sat, 27 Apr 2019 18:39:23 +0200 Date: Sat, 27 Apr 2019 18:39:23 +0200 From: Andrew Lunn To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Rob Herring , Mark Rutland , Vivien Didelot , Florian Fainelli , Heiko Stuebner , Fugang Duan , Claudiu Manoil , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Neil Armstrong , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Maxime Coquelin , Alexandre Torgue , Kalle Valo , Matthias Brugger , Li Yang , Heiner Kallweit , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190427163923.GC9816@lunn.ch> References: <1556320002-26213-1-git-send-email-ynezz@true.cz> <1556320002-26213-3-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556320002-26213-3-git-send-email-ynezz@true.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > index 8b80515..92c5642 100644 > --- a/Documentation/devicetree/bindings/net/macb.txt > +++ b/Documentation/devicetree/bindings/net/macb.txt > @@ -26,15 +26,15 @@ Required properties: > Optional elements: 'tsu_clk' > - clocks: Phandles to input clocks. > > -Optional properties: > -- nvmem-cells: phandle, reference to an nvmem node for the MAC address > -- nvmem-cell-names: string, should be "mac-address" if nvmem is to be used > - > Optional properties for PHY child node: > - reset-gpios : Should specify the gpio for phy reset > - magic-packet : If present, indicates that the hardware supports waking > up via magic packet. > - phy-handle : see ethernet.txt file in the same directory > +- mac-address: See ethernet.txt in the same directory. > +- local-mac-address: See ethernet.txt in the same directory. > +- nvmem-cells: See ethernet.txt in the same directory. > +- nvmem-cell-names: See ethernet.txt in the same directory. This looks wrong. The MAC address is not a PHY property, so should not be inside the PHY child node. phy-handle is in the wrong place, but that is a separate problem. Andrew