Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled

Willem de Bruijn
2019-04-29T03:05:02Z

On Sun, Apr 28, 2019 at 11:22 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Sun, Apr 28, 2019 at 03:45:21PM +1000, Stephen Mallon wrote:
> > Ensure that the unique timestamp identifier is incremented for skb hardware
> > timestamps, not just software timestamps.
>
> Thanks for fixing this. It has been at the back of my mind for a long
> time, but since I don't use this feature... oh well.
>
> This patch would be a candidate for stable kernels. Can you please
> add a Fixes: tag?

It is debatable whether this is a fix or a new feature. It extends
SOF_TIMESTAMPING_OPT_ID to hardware timestamps. I don't think this
would be a stable candidate.

More importantly, note that __ip6_append_data has similar logic. For
consistency the two should be updated at the same time.