From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve setting advertised modes in phy_probe
Date: Sun, 28 Apr 2019 19:04:56 +0200 [thread overview]
Message-ID: <20190428170456.GL23059@lunn.ch> (raw)
In-Reply-To: <13d4d69b-86a8-6c0d-a5a3-354f79a82170@gmail.com>
On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote:
> So far we set the advertising bitmap before setting the pause flags
> in the supported bitmap. This may cause pause not being advertised.
Hi Heiner
Pause requires that the PHY can advertise the pause bits, and that the
MAC supports pause. So by default, we don't advertise pause. The MAC
needs to say it supports pause, by calling one of
void phy_support_sym_pause(struct phy_device *phydev);
void phy_support_asym_pause(struct phy_device *phydev);
These two then copy supported into advertising.
Andrew
next prev parent reply other threads:[~2019-04-28 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 13:03 [PATCH net-next] net: phy: improve setting advertised modes in phy_probe Heiner Kallweit
2019-04-28 17:04 ` Andrew Lunn [this message]
2019-04-28 18:10 ` Heiner Kallweit
2019-04-28 21:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428170456.GL23059@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).