From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=A+bm=S6=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6472FC43218
	for <netdev@archiver.kernel.org>; Sun, 28 Apr 2019 17:05:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 2657C20693
	for <netdev@archiver.kernel.org>; Sun, 28 Apr 2019 17:05:02 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="naJmKB+O"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726932AbfD1RFA (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 28 Apr 2019 13:05:00 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:47418 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726674AbfD1RFA (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 28 Apr 2019 13:05:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=qQ7k0aLeJNWPfktSyGr/Ftr3Qy0LBeGQGL+q95HXUyw=; b=naJmKB+OObFx07xRfow9ZN21zm
        X0MlvteKBC2BgD+2zGg+qAdrXI1RnRCiO0E3elT1OQQkhf1752Bx821xKtNA/hf9ZA5FocxCRtm1T
        kekw3vbTA1X4ETgo5Fv8rRYqHWT1nY8FBn7bfC9W6jiA5y6cZ2k8RuKwIH/75+BhHERg=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hKnEW-00014B-MY; Sun, 28 Apr 2019 19:04:56 +0200
Date:   Sun, 28 Apr 2019 19:04:56 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve setting advertised modes in
 phy_probe
Message-ID: <20190428170456.GL23059@lunn.ch>
References: <13d4d69b-86a8-6c0d-a5a3-354f79a82170@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13d4d69b-86a8-6c0d-a5a3-354f79a82170@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, Apr 28, 2019 at 03:03:37PM +0200, Heiner Kallweit wrote:
> So far we set the advertising bitmap before setting the pause flags
> in the supported bitmap. This may cause pause not being advertised.

Hi Heiner

Pause requires that the PHY can advertise the pause bits, and that the
MAC supports pause. So by default, we don't advertise pause. The MAC
needs to say it supports pause, by calling one of

void phy_support_sym_pause(struct phy_device *phydev);
void phy_support_asym_pause(struct phy_device *phydev);

These two then copy supported into advertising.

      Andrew