From: Stephen Hemminger <stephen@networkplumber.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] tc: add support for plug qdisc
Date: Mon, 29 Apr 2019 10:16:38 -0700 [thread overview]
Message-ID: <20190429101638.1a250c01@hermes.lan> (raw)
In-Reply-To: <b6629ad2cb9afe49615360d359fce60ef2b19915.camel@redhat.com>
On Fri, 26 Apr 2019 10:47:52 +0200
Paolo Abeni <pabeni@redhat.com> wrote:
> Hi,
>
> On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote:
> > On Wed, 24 Apr 2019 18:29:39 +0200
> > Paolo Abeni <pabeni@redhat.com> wrote:
> >
> > > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> > > +{
> > > + /* dummy implementation as sch_plug does not implement a dump op */
> > > + return 0;
> > > +}
> > > +
> >
> > All qdisc must dump their state in same form as the parse option.
>
> Thank you for the feedback.
>
> The problem here is that the sch_plug qdisc does not implement the
> dump() qdisc_op, so this callback has nothing to dump.
>
> Must I patch sch_plug first?
>
> Thanks,
>
> Paolo
>
OK, lets put the patch in as is for now. And then fix the kernel, then add print?
next prev parent reply other threads:[~2019-04-29 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 16:29 [PATCH iproute2-next] tc: add support for plug qdisc Paolo Abeni
2019-04-24 20:47 ` Stephen Hemminger
2019-04-24 20:49 ` Stephen Hemminger
2019-04-26 8:47 ` Paolo Abeni
2019-04-29 17:16 ` Stephen Hemminger [this message]
2019-04-30 15:00 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429101638.1a250c01@hermes.lan \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).