From: Christoph Hellwig <hch@infradead.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net_sched: force endianness annotation
Date: Mon, 29 Apr 2019 05:09:36 -0700 [thread overview]
Message-ID: <20190429120936.GA21405@infradead.org> (raw)
In-Reply-To: <1556430899-11018-1-git-send-email-hofrat@osadl.org>
On Sun, Apr 28, 2019 at 07:54:59AM +0200, Nicholas Mc Guire wrote:
> While the endiannes is being handled correctly sparse was unhappy with
> the missing annotation as be16_to_cpu()/be32_to_cpu() expects a __be16
> respectively __be32. To mitigate this annotation issue forced annotation
> is introduced. Note that this patch has no impact on the generated binary.
Every __force needs a comment explaining why it actually іs fine in
this particular case. Even more bonus points for finding a solution
that does not require the __force.
prev parent reply other threads:[~2019-04-29 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 5:54 [PATCH] net_sched: force endianness annotation Nicholas Mc Guire
2019-04-28 18:17 ` Cong Wang
2019-04-29 10:11 ` Edward Cree
2019-04-29 10:44 ` Nicholas Mc Guire
2019-04-29 11:11 ` Edward Cree
2019-04-29 11:29 ` Nicholas Mc Guire
2019-04-29 12:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429120936.GA21405@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).