From: Richard Cochran <richardcochran@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Stephen Mallon <stephen.mallon@sydney.edu.au>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled
Date: Mon, 29 Apr 2019 08:02:42 -0700 [thread overview]
Message-ID: <20190429150242.vckwna4bt4xynzjo@localhost> (raw)
In-Reply-To: <CAF=yD-JLcmyoJ6tq1osgrQbXs6+As0R+J-ofU+XwQWcvaW+LBg@mail.gmail.com>
On Sun, Apr 28, 2019 at 10:57:57PM -0400, Willem de Bruijn wrote:
> It is debatable whether this is a fix or a new feature. It extends
> SOF_TIMESTAMPING_OPT_ID to hardware timestamps. I don't think this
> would be a stable candidate.
Was the original series advertised as SW timestamping only?
If so, I missed that at the time. After seeing it not work, I meant
to fix it, but never got around to it. So to me this is a known
issue.
> More importantly, note that __ip6_append_data has similar logic. For
> consistency the two should be updated at the same time.
+1
Thanks,
Richard
next prev parent reply other threads:[~2019-04-29 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 5:45 [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled Stephen Mallon
2019-04-28 15:19 ` Richard Cochran
2019-04-29 2:57 ` Willem de Bruijn
2019-04-29 15:02 ` Richard Cochran [this message]
2019-04-29 15:32 ` Willem de Bruijn
2019-04-30 1:17 ` Stephen Mallon
2019-04-30 2:54 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429150242.vckwna4bt4xynzjo@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen.mallon@sydney.edu.au \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox