From: Ido Schimmel <idosch@mellanox.com>
To: David Ahern <dsahern@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v3 net-next 3/3] ipv4: Move exception bucket to nh_common
Date: Tue, 30 Apr 2019 07:17:03 +0000 [thread overview]
Message-ID: <20190430071701.GB20525@splinter> (raw)
In-Reply-To: <20190429161619.23671-4-dsahern@kernel.org>
On Mon, Apr 29, 2019 at 09:16:19AM -0700, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
>
> Similar to the cached routes, make IPv4 exceptions accessible when
> using an IPv6 nexthop struct with IPv4 routes. Simplify the exception
> functions by passing in fib_nh_common since that is all it needs,
> and then cleanup the call sites that have extraneous fib_nh conversions.
>
> As with the cached routes this is a change in location only, from fib_nh
> up to fib_nh_common; no functional change intended:
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
prev parent reply other threads:[~2019-04-30 7:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 16:16 [PATCH v3 net-next 0/3] ipv4: Move location of pcpu route cache and exceptions David Ahern
2019-04-29 16:16 ` [PATCH v3 net-next 1/3] ipv4: Move cached routes to fib_nh_common David Ahern
2019-04-30 6:40 ` Ido Schimmel
2019-04-30 14:27 ` David Ahern
2019-04-29 16:16 ` [PATCH v3 net-next 2/3] ipv4: Pass fib_nh_common to rt_cache_route David Ahern
2019-04-30 6:56 ` Ido Schimmel
2019-04-29 16:16 ` [PATCH v3 net-next 3/3] ipv4: Move exception bucket to nh_common David Ahern
2019-04-30 7:17 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430071701.GB20525@splinter \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).