* [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m
@ 2019-04-30 9:28 Geert Uytterhoeven
2019-04-30 9:38 ` Daniel Lezcano
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-04-30 9:28 UTC (permalink / raw)
To: Daniel Lezcano, Zhang Rui, Eduardo Valentin, Matthias Brugger
Cc: Jiri Pirko, Ido Schimmel, David S . Miller, linux-pm, netdev,
linux-kernel, Geert Uytterhoeven
The THERMAL configuration option was changed from tristate to bool, but
a dependency on THERMAL=m was forgotten, leading to a warning when
running "make savedefconfig":
boolean symbol THERMAL tested for 'm'? test forced to 'n'
Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
@@ -22,7 +22,6 @@ config MLXSW_CORE_HWMON
config MLXSW_CORE_THERMAL
bool "Thermal zone support for Mellanox Technologies Switch ASICs"
depends on MLXSW_CORE && THERMAL
- depends on !(MLXSW_CORE=y && THERMAL=m)
default y
---help---
Say Y here if you want to automatically control fans speed according
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m
2019-04-30 9:28 [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m Geert Uytterhoeven
@ 2019-04-30 9:38 ` Daniel Lezcano
2019-04-30 10:16 ` Ido Schimmel
2019-05-03 18:37 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2019-04-30 9:38 UTC (permalink / raw)
To: Geert Uytterhoeven, Zhang Rui, Eduardo Valentin, Matthias Brugger
Cc: Jiri Pirko, Ido Schimmel, David S . Miller, linux-pm, netdev,
linux-kernel
On 30/04/2019 11:28, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks!
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> @@ -22,7 +22,6 @@ config MLXSW_CORE_HWMON
> config MLXSW_CORE_THERMAL
> bool "Thermal zone support for Mellanox Technologies Switch ASICs"
> depends on MLXSW_CORE && THERMAL
> - depends on !(MLXSW_CORE=y && THERMAL=m)
> default y
> ---help---
> Say Y here if you want to automatically control fans speed according
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m
2019-04-30 9:28 [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m Geert Uytterhoeven
2019-04-30 9:38 ` Daniel Lezcano
@ 2019-04-30 10:16 ` Ido Schimmel
2019-05-03 18:37 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Ido Schimmel @ 2019-04-30 10:16 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Zhang Rui, Eduardo Valentin, Matthias Brugger,
Jiri Pirko, David S . Miller, linux-pm@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Apr 30, 2019 at 11:28:32AM +0200, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
I assume this will be applied to the thermal tree?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m
2019-04-30 9:28 [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m Geert Uytterhoeven
2019-04-30 9:38 ` Daniel Lezcano
2019-04-30 10:16 ` Ido Schimmel
@ 2019-05-03 18:37 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2019-05-03 18:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Lezcano, Zhang Rui, Eduardo Valentin, Matthias Brugger,
Jiri Pirko, Ido Schimmel, David S . Miller, linux-pm, netdev,
linux-kernel
On Tue, 30 Apr 2019 at 11:29, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
This also fixes olddefconfig, image_name and other targets:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-03 18:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-30 9:28 [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m Geert Uytterhoeven
2019-04-30 9:38 ` Daniel Lezcano
2019-04-30 10:16 ` Ido Schimmel
2019-05-03 18:37 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).