From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
pabeni@redhat.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] udp: fix GRO packet of death
Date: Wed, 01 May 2019 22:31:27 -0400 (EDT) [thread overview]
Message-ID: <20190501.223127.269942837516364133.davem@davemloft.net> (raw)
In-Reply-To: <20190502015628.22215-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 1 May 2019 18:56:28 -0700
> syzbot was able to crash host by sending UDP packets with a 0 payload.
>
> TCP does not have this issue since we do not aggregate packets without
> payload.
>
> Since dev_gro_receive() sets gso_size based on skb_gro_len(skb)
> it seems not worth trying to cope with padded packets.
...
> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Ugh :(
Applied and queued up for -stable, thanks Eric.
next prev parent reply other threads:[~2019-05-02 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 1:56 [PATCH net] udp: fix GRO packet of death Eric Dumazet
2019-05-02 2:31 ` David Miller [this message]
2019-05-02 8:24 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501.223127.269942837516364133.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).