Netdev List
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: davem@davemloft.net
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	hch@lst.de, netdev@vger.kernel.org
Subject: [PATCH 1/5] net: Increase the size of skb_frag_t
Date: Tue, 30 Apr 2019 21:17:53 -0700	[thread overview]
Message-ID: <20190501041757.8647-3-willy@infradead.org> (raw)
In-Reply-To: <20190501041757.8647-1-willy@infradead.org>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

To increase commonality between block and net, we are going to replace
the skb_frag_t with the bio_vec.  This patch increases the size of
skb_frag_t on 32-bit machines from 8 bytes to 12 bytes.  The size is
unchanged on 64-bit machines.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/linux/skbuff.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 9027a8c4219f..23f05c64aa31 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -318,13 +318,8 @@ struct skb_frag_struct {
 	struct {
 		struct page *p;
 	} page;
-#if (BITS_PER_LONG > 32) || (PAGE_SIZE >= 65536)
 	__u32 page_offset;
 	__u32 size;
-#else
-	__u16 page_offset;
-	__u16 size;
-#endif
 };
 
 /**
-- 
2.20.1


  reply	other threads:[~2019-05-01  4:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  4:17 [PATCH 0/5] Beginnings of skb_frag -> bio_vec conversion Matthew Wilcox
2019-05-01  4:17 ` Matthew Wilcox [this message]
2019-05-01  4:17 ` [PATCH 2/5] net: Reorder the contents of skb_frag_t Matthew Wilcox
2019-05-01  4:17 ` [PATCH 3/5] net: Include bvec.h in skbuff.h Matthew Wilcox
2019-05-01  4:17 ` [PATCH 4/5] net: Use skb accessors for skb->page Matthew Wilcox
2019-05-02 10:21   ` kbuild test robot
2019-05-01  4:17 ` [PATCH 5/5] net: Rename skb_frag page to bv_page Matthew Wilcox
2019-05-01  8:14 ` [PATCH 0/5] Beginnings of skb_frag -> bio_vec conversion Eric Dumazet
2019-05-01  9:44   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501041757.8647-3-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox