* [PATCH] net: macb: remove redundant struct phy_device declaration
@ 2019-05-03 10:36 Nicolas Ferre
2019-05-03 12:29 ` Andrew Lunn
2019-05-03 14:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Ferre @ 2019-05-03 10:36 UTC (permalink / raw)
To: Claudiu Beznea, linux-arm-kernel, David S. Miller, netdev
Cc: linux-kernel, Alexandre Belloni, michal.simek, harini.katakam,
Nicolas Ferre
While moving the chunk of code during 739de9a1563a
("net: macb: Reorganize macb_mii bringup"), the declaration of
struct phy_device declaration was kept. It's not useful in this
function as we alrady have a phydev pointer.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
drivers/net/ethernet/cadence/macb_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 009ed4c1baf3..59531adcbb42 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -530,8 +530,6 @@ static int macb_mii_probe(struct net_device *dev)
*/
if (!bp->phy_node && !phy_find_first(bp->mii_bus)) {
for (i = 0; i < PHY_MAX_ADDR; i++) {
- struct phy_device *phydev;
-
phydev = mdiobus_scan(bp->mii_bus, i);
if (IS_ERR(phydev) &&
PTR_ERR(phydev) != -ENODEV) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: macb: remove redundant struct phy_device declaration
2019-05-03 10:36 [PATCH] net: macb: remove redundant struct phy_device declaration Nicolas Ferre
@ 2019-05-03 12:29 ` Andrew Lunn
2019-05-03 14:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-05-03 12:29 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Claudiu Beznea, linux-arm-kernel, David S. Miller, netdev,
harini.katakam, Alexandre Belloni, linux-kernel, michal.simek
On Fri, May 03, 2019 at 12:36:28PM +0200, Nicolas Ferre wrote:
> While moving the chunk of code during 739de9a1563a
> ("net: macb: Reorganize macb_mii bringup"), the declaration of
> struct phy_device declaration was kept. It's not useful in this
> function as we alrady have a phydev pointer.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: macb: remove redundant struct phy_device declaration
2019-05-03 10:36 [PATCH] net: macb: remove redundant struct phy_device declaration Nicolas Ferre
2019-05-03 12:29 ` Andrew Lunn
@ 2019-05-03 14:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-03 14:26 UTC (permalink / raw)
To: nicolas.ferre
Cc: claudiu.beznea, linux-arm-kernel, netdev, linux-kernel,
alexandre.belloni, michal.simek, harini.katakam
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: Fri, 3 May 2019 12:36:28 +0200
> While moving the chunk of code during 739de9a1563a
> ("net: macb: Reorganize macb_mii bringup"), the declaration of
> struct phy_device declaration was kept. It's not useful in this
> function as we alrady have a phydev pointer.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-03 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-03 10:36 [PATCH] net: macb: remove redundant struct phy_device declaration Nicolas Ferre
2019-05-03 12:29 ` Andrew Lunn
2019-05-03 14:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).