From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C2EC43219 for ; Fri, 3 May 2019 00:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9613D2087F for ; Fri, 3 May 2019 00:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556843204; bh=E51g641q2MwftWilIwtdgawIewraRUot0Q8Lmt+r1bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sLiyoj+Qby4Pq3PRKyFF07ncQ+t+f7jTDjAN2RRV+a2tZIQQhioX0JXoGhDEwEZoL wH2IJvzkb8DEFNstc0dW2n7zGbK5LA9cGaDb//AWF7RmmpkcEI6IB1FV+MuNGzhfvs 3yXUhZuDnMWPQz7J8CE/gaeAQ44spXCZCc9zqWVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbfECAZu (ORCPT ); Thu, 2 May 2019 20:25:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:43754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbfECAZt (ORCPT ); Thu, 2 May 2019 20:25:49 -0400 Received: from quaco.ghostprotocols.net (adsl-173-228-226-134.prtc.net [173.228.226.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA1D520C01; Fri, 3 May 2019 00:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556843148; bh=E51g641q2MwftWilIwtdgawIewraRUot0Q8Lmt+r1bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S6O6Nxwn10nX/JWXRbiE5Ldez9d3j9hsajA+zxkczgfs7O/DA6aVzUAP/3ALvsjmZ E4dpPJKUNDN6/qgx9BsMwAWrH1otbiYf9go9pl8T0H4piKgXXsExAgWXCdmHhYssBl KyfR1EWdwZ0RrXBCqASyCkX8ON18L3Fy0EuOxUAA= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Bo YU , Adrian Hunter , Alexander Shishkin , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Peter Zijlstra , Song Liu , Yonghong Song , bpf@vger.kernel.org, netdev@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 01/11] perf bpf: Return value with unlocking in perf_env__find_btf() Date: Thu, 2 May 2019 20:25:23 -0400 Message-Id: <20190503002533.29359-2-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503002533.29359-1-acme@kernel.org> References: <20190503002533.29359-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Bo YU In perf_env__find_btf(), we're returning without unlocking "env->bpf_progs.lock". There may be cause lockdep issue. Detected by CoversityScan, CID# 1444762:(program hangs(LOCK)) Signed-off-by: Bo YU Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Martin KaFai Lau Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Song Liu Cc: Yonghong Song Cc: bpf@vger.kernel.org Cc: netdev@vger.kernel.org Fixes: 2db7b1e0bd49d: (perf bpf: Return NULL when RB tree lookup fails in perf_env__find_btf()) Link: http://lkml.kernel.org/r/20190422080138.10088-1-tsu.yubo@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c index 9494f9dc61ec..6a3eaf7d9353 100644 --- a/tools/perf/util/env.c +++ b/tools/perf/util/env.c @@ -115,8 +115,8 @@ struct btf_node *perf_env__find_btf(struct perf_env *env, __u32 btf_id) } node = NULL; - up_read(&env->bpf_progs.lock); out: + up_read(&env->bpf_progs.lock); return node; } -- 2.20.1