From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD72C43219 for ; Fri, 3 May 2019 17:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 899F8206C3 for ; Fri, 3 May 2019 17:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728446AbfECRFO (ORCPT ); Fri, 3 May 2019 13:05:14 -0400 Received: from mail.us.es ([193.147.175.20]:45070 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfECRFO (ORCPT ); Fri, 3 May 2019 13:05:14 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id BEBBEE8624 for ; Fri, 3 May 2019 19:05:12 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id AF638DA70E for ; Fri, 3 May 2019 19:05:12 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id A4EF5DA708; Fri, 3 May 2019 19:05:12 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9990DDA704; Fri, 3 May 2019 19:05:10 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 03 May 2019 19:05:10 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 721414265A32; Fri, 3 May 2019 19:05:10 +0200 (CEST) Date: Fri, 3 May 2019 19:05:10 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Nicolas Dichtel Cc: Kristian Evensen , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Florian Westphal , David Miller Subject: Re: [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression Message-ID: <20190503170510.dn3z2363bsc5y4zp@salvia> References: <20190503154007.32495-1-kristian.evensen@gmail.com> <0326116f-f163-5ae1-ce19-6a891323eb03@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0326116f-f163-5ae1-ce19-6a891323eb03@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 03, 2019 at 07:02:54PM +0200, Nicolas Dichtel wrote: > Please, keep in CC all involved people. > > Le 03/05/2019 à 17:40, Kristian Evensen a écrit : > > Commit 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter > > on flush") introduced a user-space regression when flushing connection > > track entries. Before this commit, the nfgen_family field was not used > > by the kernel and all entries were removed. Since this commit, > > nfgen_family is used to filter out entries that should not be removed. > > One example a broken tool is conntrack. conntrack always sets > > nfgen_family to AF_INET, so after 59c08c69c278 only IPv4 entries were > > removed with the -F parameter. > > > > Pablo Neira Ayuso suggested using nfgenmsg->version to resolve the > > regression, and this commit implements his suggestion. nfgenmsg->version > > is so far set to zero, so it is well-suited to be used as a flag for > > selecting old or new flush behavior. If version is 0, nfgen_family is > > ignored and all entries are used. If user-space sets the version to one > > (or any other value than 0), then the new behavior is used. As version > > only can have two valid values, I chose not to add a new > > NFNETLINK_VERSION-constant. > > > > Fixes: 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter > > on flush") > > > Please, don't break the fixes line and don't separate it from other tags with an > empty line. Will fix this before applying, no worries. > > Reported-by: Nicolas Dichtel > > Suggested-by: Pablo Neira Ayuso > > Signed-off-by: Kristian Evensen > Tested-by: Nicolas Dichtel