From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFADC43219 for ; Sat, 4 May 2019 05:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C88A720645 for ; Sat, 4 May 2019 05:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbfEDFhj (ORCPT ); Sat, 4 May 2019 01:37:39 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfEDFhj (ORCPT ); Sat, 4 May 2019 01:37:39 -0400 Received: from localhost (unknown [75.104.87.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CB5CC14DA6485; Fri, 3 May 2019 22:37:35 -0700 (PDT) Date: Sat, 04 May 2019 01:37:31 -0400 (EDT) Message-Id: <20190504.013731.38990269717923489.davem@davemloft.net> To: echaudro@redhat.com Cc: netdev@vger.kernel.org, pshelar@ovn.org, dev@openvswitch.org Subject: Re: [PATCH net-next] net: openvswitch: return an error instead of doing BUG_ON() From: David Miller In-Reply-To: <20190502201238.21698.58459.stgit@netdev64> References: <20190502201238.21698.58459.stgit@netdev64> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 May 2019 22:37:39 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eelco Chaudron Date: Thu, 2 May 2019 16:12:38 -0400 > For all other error cases in queue_userspace_packet() the error is > returned, so it makes sense to do the same for these two error cases. > > Reported-by: Davide Caratti > Signed-off-by: Eelco Chaudron Applied.