From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9150FC004C9 for ; Sun, 5 May 2019 17:29:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C02F20675 for ; Sun, 5 May 2019 17:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727875AbfEER3s (ORCPT ); Sun, 5 May 2019 13:29:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbfEER3s (ORCPT ); Sun, 5 May 2019 13:29:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 27E6614DA6460; Sun, 5 May 2019 10:29:47 -0700 (PDT) Date: Sun, 05 May 2019 10:29:46 -0700 (PDT) Message-Id: <20190505.102946.1600019216217248155.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: esben@geanix.com, michal.simek@xilinx.com, andrew@lunn.ch, yang.wei9@zte.com.cn, yuehaibing@huawei.com, mcgrof@kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2 net-next] net: ll_temac: Fix an NULL vs IS_ERR() check in temac_open() From: David Miller In-Reply-To: <20190503125024.GF29695@mwanda> References: <20190503125024.GF29695@mwanda> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 05 May 2019 10:29:47 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Fri, 3 May 2019 15:50:24 +0300 > The phy_connect() function doesn't return NULL pointers. It returns > error pointers on error, so I have updated the check. > > Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms") > Signed-off-by: Dan Carpenter Applied.