From: Jiri Pirko <jiri@resnulli.us>
To: Moshe Shemesh <moshe@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>
Subject: Re: [net-next 11/15] net/mlx5: Add support for FW reporter dump
Date: Mon, 6 May 2019 13:37:36 +0200 [thread overview]
Message-ID: <20190506113736.GA2280@nanopsycho> (raw)
In-Reply-To: <923129a3-d5e0-3b1e-932c-efdc96dba676@mellanox.com>
Mon, May 06, 2019 at 12:51:24PM CEST, moshe@mellanox.com wrote:
>
>
>On 5/5/2019 6:49 PM, Jiri Pirko wrote:
>> Sun, May 05, 2019 at 02:33:27AM CEST, saeedm@mellanox.com wrote:
>>> From: Moshe Shemesh <moshe@mellanox.com>
>>>
>>> Add support of dump callback for mlx5 FW reporter.
>>> Once we trigger FW dump, the FW will write the core dump to its raw data
>>> buffer. The tracer translates the raw data to traces and save it to a
>>> buffer. Once dump is done, the saved traces data is filled as objects
>>> into the dump buffer.
>>>
>>
>> [...]
>>
>>> +static void mlx5_fw_tracer_save_trace(struct mlx5_fw_tracer *tracer,
>>> + u64 timestamp, bool lost,
>>> + u8 event_id, char *msg)
>>> +{
>>> + char *saved_traces = tracer->sbuff.traces_buff;
>>> + u32 offset;
>>> +
>>> + mutex_lock(&tracer->sbuff.lock);
>>> + offset = tracer->sbuff.saved_traces_index * TRACE_STR_LINE;
>>> + snprintf(saved_traces + offset, TRACE_STR_LINE,
>>> + "%s [0x%llx] %d [0x%x] %s", dev_name(&tracer->dev->pdev->dev),
>>> + timestamp, lost, event_id, msg);
>>
>> Please format this using fmsg helpers instead.
>>
>
>Same here, I want to keep the format as is, not change it.
"as is" - where exactly?
>>
>>> +
>>> + tracer->sbuff.saved_traces_index =
>>> + (tracer->sbuff.saved_traces_index + 1) & (SAVED_TRACES_NUM - 1);
>>> + mutex_unlock(&tracer->sbuff.lock);
>>> +}
>>
>> [...]
>>
next prev parent reply other threads:[~2019-05-06 11:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 0:32 [pull request][net-next 00/15] Mellanox, mlx5 Firmware devlink health and sw reset Saeed Mahameed
2019-05-05 0:32 ` [net-next 01/15] net/mlx5: Move all devlink related functions calls to devlink.c Saeed Mahameed
2019-05-05 0:32 ` [net-next 02/15] net/mlx5: Add Vendor Specific Capability access gateway Saeed Mahameed
2019-05-05 0:33 ` [net-next 03/15] net/mlx5: Add Crdump FW snapshot support Saeed Mahameed
2019-05-05 15:36 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 04/15] net/mlx5: Add support for devlink region_snapshot parameter Saeed Mahameed
2019-05-05 0:33 ` [net-next 05/15] net/mlx5: Handle SW reset of FW in error flow Saeed Mahameed
2019-05-05 0:33 ` [net-next 06/15] net/mlx5: Control CR-space access by different PFs Saeed Mahameed
2019-05-05 0:33 ` [net-next 07/15] net/mlx5: Issue SW reset on FW assert Saeed Mahameed
2019-05-05 15:38 ` Jiri Pirko
2019-05-06 10:44 ` Moshe Shemesh
2019-05-05 0:33 ` [net-next 08/15] net/mlx5: Refactor print health info Saeed Mahameed
2019-05-05 15:42 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 09/15] net/mlx5: Create FW devlink health reporter Saeed Mahameed
2019-05-05 15:42 ` Jiri Pirko
2019-05-06 10:45 ` Moshe Shemesh
2019-05-06 11:38 ` Jiri Pirko
2019-05-06 19:52 ` Saeed Mahameed
2019-05-06 21:46 ` Alexei Starovoitov
2019-05-07 5:59 ` Jiri Pirko
2019-05-07 6:01 ` Jiri Pirko
2019-05-07 0:11 ` Jakub Kicinski
2019-05-05 0:33 ` [net-next 10/15] net/mlx5: Add core dump register access functions Saeed Mahameed
2019-05-05 0:33 ` [net-next 11/15] net/mlx5: Add support for FW reporter dump Saeed Mahameed
2019-05-05 15:49 ` Jiri Pirko
2019-05-06 10:51 ` Moshe Shemesh
2019-05-06 11:37 ` Jiri Pirko [this message]
2019-05-05 0:33 ` [net-next 12/15] net/mlx5: Report devlink health on FW issues Saeed Mahameed
2019-05-05 0:33 ` [net-next 13/15] net/mlx5: Add fw fatal devlink health reporter Saeed Mahameed
2019-05-05 0:33 ` [net-next 14/15] net/mlx5: Add support for FW fatal reporter dump Saeed Mahameed
2019-05-05 15:52 ` Jiri Pirko
2019-05-06 10:54 ` Moshe Shemesh
2019-05-06 11:42 ` Jiri Pirko
2019-05-05 0:33 ` [net-next 15/15] net/mlx5: Report devlink health on FW fatal issues Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506113736.GA2280@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox