From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0FAAC04A6B for ; Mon, 6 May 2019 13:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC029206A3 for ; Mon, 6 May 2019 13:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725853AbfEFNQM (ORCPT ); Mon, 6 May 2019 09:16:12 -0400 Received: from mail.us.es ([193.147.175.20]:40098 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbfEFNQM (ORCPT ); Mon, 6 May 2019 09:16:12 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 3468A9D3CC for ; Mon, 6 May 2019 15:16:10 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2564EDA716 for ; Mon, 6 May 2019 15:16:10 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 1AE9ADA705; Mon, 6 May 2019 15:16:10 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 4CECBDA717; Mon, 6 May 2019 15:16:06 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 06 May 2019 15:16:06 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 2503C4265A32; Mon, 6 May 2019 15:16:06 +0200 (CEST) Date: Mon, 6 May 2019 15:16:05 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Nicolas Dichtel Cc: Kristian Evensen , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression Message-ID: <20190506131605.kapyns6gkyphbea2@salvia> References: <20190503154007.32495-1-kristian.evensen@gmail.com> <20190505223229.3ujqpwmuefd3wh7b@salvia> <4ecbebbb-0a7f-6d45-c2c0-00dee746e573@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4ecbebbb-0a7f-6d45-c2c0-00dee746e573@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 06, 2019 at 10:49:52AM +0200, Nicolas Dichtel wrote: > Le 06/05/2019 à 00:32, Pablo Neira Ayuso a écrit : > > On Fri, May 03, 2019 at 05:40:07PM +0200, Kristian Evensen wrote: > >> Commit 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter > >> on flush") introduced a user-space regression when flushing connection > >> track entries. Before this commit, the nfgen_family field was not used > >> by the kernel and all entries were removed. Since this commit, > >> nfgen_family is used to filter out entries that should not be removed. > >> One example a broken tool is conntrack. conntrack always sets > >> nfgen_family to AF_INET, so after 59c08c69c278 only IPv4 entries were > >> removed with the -F parameter. > >> > >> Pablo Neira Ayuso suggested using nfgenmsg->version to resolve the > >> regression, and this commit implements his suggestion. nfgenmsg->version > >> is so far set to zero, so it is well-suited to be used as a flag for > >> selecting old or new flush behavior. If version is 0, nfgen_family is > >> ignored and all entries are used. If user-space sets the version to one > >> (or any other value than 0), then the new behavior is used. As version > >> only can have two valid values, I chose not to add a new > >> NFNETLINK_VERSION-constant. > > > > Applied, thanks. > > > Thank you. > Is it possible to queue this for stable? Sure, as soon as this hits Linus' tree.