From: Miroslav Lichvar <mlichvar@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>, Jiri Benc <jbenc@redhat.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
stefan.sorensen@spectralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device
Date: Tue, 7 May 2019 10:35:59 +0200 [thread overview]
Message-ID: <20190507083559.GD13858@localhost> (raw)
In-Reply-To: <20190506140123.k2kw7apaubvljsa5@localhost>
On Mon, May 06, 2019 at 07:01:23AM -0700, Richard Cochran wrote:
> On Thu, Apr 25, 2019 at 09:40:06PM +0800, Hangbin Liu wrote:
> > Would you please help have a look at it and see which way we should use?
> > Drop SIOCSHWTSTAMP in container or add a filter on macvlan(maybe only in
> > container)?
>
> I vote for dropping SIOCSHWTSTAMP altogether. Why? Because the
> filter idea means that the ioctl will magically succeed or fail, based
> on the unknowable state of the container's host.
That's a good point. I agree that SIOCSHWTSTAMP always failing would
be a less surprising behavior than failing only with some specific
configurations.
> It is better IMHO to
> let the admin of the host set up HWTSTAMP globally (like with
> hwtstamp_ctl for example) and configure the apps appropriately (like
> with ptp4l --hwts_filter=check).
Makes sense to me.
Some applications that support HW timestamping cannot do that
currently (they call SIOCSHWTSTAMP even if nothing is changing), but
it shouldn't be difficult to add support for this case.
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2019-05-07 8:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 2:23 [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Hangbin Liu
2019-03-20 18:05 ` David Miller
2019-04-17 8:05 ` Hangbin Liu
2019-04-17 15:43 ` Richard Cochran
2019-04-17 18:59 ` Jiri Benc
2019-04-18 3:31 ` Richard Cochran
2019-04-18 6:10 ` Hangbin Liu
2019-04-18 8:05 ` Miroslav Lichvar
2019-04-23 4:18 ` Hangbin Liu
2019-04-23 8:31 ` Miroslav Lichvar
2019-04-23 9:15 ` Hangbin Liu
2019-04-23 9:32 ` Miroslav Lichvar
2019-04-25 13:40 ` Hangbin Liu
2019-05-06 7:34 ` Hangbin Liu
2019-05-06 14:01 ` Richard Cochran
2019-05-07 8:35 ` Miroslav Lichvar [this message]
2019-05-08 1:41 ` Hangbin Liu
2019-05-08 13:58 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507083559.GD13858@localhost \
--to=mlichvar@redhat.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=kaber@trash.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).