From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB1F7C04A6B for ; Wed, 8 May 2019 16:52:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7375120644 for ; Wed, 8 May 2019 16:52:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="oyj3rsut" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728780AbfEHQwX (ORCPT ); Wed, 8 May 2019 12:52:23 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40648 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728044AbfEHQwX (ORCPT ); Wed, 8 May 2019 12:52:23 -0400 Received: by mail-lf1-f66.google.com with SMTP id o16so15042449lfl.7 for ; Wed, 08 May 2019 09:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tSbV0hIT6zSzNhIts7V7OvvP5JqoQNMoPHnS6WoTwu8=; b=oyj3rsutc76/lKGTt04GMx8W276cXzfR4dx7Xe1ihD7rjDst4YU83+FjRiHbFMisRI OLnkQLOrHuZwkJMJLH9CpYWpp4c8MsAQOzNolxjSPFLQddH9DdCyEGgd8olUv0ySASMm psqUqlH+41hNneHpw8Y7l+7uqrKPjjjDvgQ/zgcdRf0kzbW9YhlWvQ9ecvHULhVkhFR2 AEGLfDOvOu25qALM7Szhv5EfIjOKIcFGQCVmt9ZHaZiuaN+eBZUCGTKJQ/SxTR3bIKNe T0R0ee28KJmEOP1BY/ySW+8KsW6Nv56UguES7n2e9a+VNDt+i7vgO8gywO02d0WfATR7 Obzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tSbV0hIT6zSzNhIts7V7OvvP5JqoQNMoPHnS6WoTwu8=; b=HZDI9sx1Hc+16/ZtzSBf7pr3CPKKh4nxone9IOyo9qJDdNgOTA6CcI+q4NGBKv6sw/ T/Gm78oHAgAj0RGOBVTFqLbn94qr+HB4Tpfnc6GReOBsfhXMjQJNmlNxv0e2hxTp+Sl5 jU0GCasqeMIIaMyxO/7aVjLoGMq34rh7YoLDOon3RA32llVjYvDMu3P2tbtOaXHDfw1D lOM+dgvSKn5QRoQs2TNhHasfAc7aWKKfTABBlcVRdI/Yd9FmguW7QPQ2ejdMLfGYEIgC YfrPhC3fjVso2qKVo39FOTd+rfeHJ+jJjFOqwGR0vvalaDK8gFXzburjPyRpjnxMIL16 rOug== X-Gm-Message-State: APjAAAVnGg3JyaIgsfa+CIizJM26Il3rY23UQxJWYOmofHaDHT9MB86U EblQgyXTKVdxyGCafV7Wvlm0Og== X-Google-Smtp-Source: APXvYqyZ2r82pYlOtlxeZg0hA3XRugj4mYMr3E0JZJxVbFgxTXFUahuO3LZtq184KFLdKIxu7DBYOA== X-Received: by 2002:ac2:490c:: with SMTP id n12mr9072188lfi.4.1557334341234; Wed, 08 May 2019 09:52:21 -0700 (PDT) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id p87sm3725885ljp.82.2019.05.08.09.52.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 09:52:20 -0700 (PDT) Date: Wed, 8 May 2019 18:52:20 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Sergei Shtylyov Cc: Ulrich Hecht , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, wsa@the-dreams.de, horms@verge.net.au, magnus.damm@gmail.com Subject: Re: [PATCH] ravb: implement MTU change while device is up Message-ID: <20190508165219.GA26309@bigcity.dyn.berto.se> References: <1557328882-24307-1-git-send-email-uli+renesas@fpond.eu> <1f7be29e-c85a-d63d-c83f-357a76e8ca45@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f7be29e-c85a-d63d-c83f-357a76e8ca45@cogentembedded.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Sergei, On 2019-05-08 18:59:01 +0300, Sergei Shtylyov wrote: > Hello! > > On 05/08/2019 06:21 PM, Ulrich Hecht wrote: > > > Uses the same method as various other drivers: shut the device down, > > change the MTU, then bring it back up again. > > > > Tested on Renesas D3 Draak board. > > > > Signed-off-by: Ulrich Hecht > > You should have CC'ed me (as an reviewer for the Renesas drivers). > > > --- > > drivers/net/ethernet/renesas/ravb_main.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > What about sh_eth? > > > > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > > index ef8f089..02c247c 100644 > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > @@ -1810,13 +1810,16 @@ static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd) > > > > static int ravb_change_mtu(struct net_device *ndev, int new_mtu) > > { > > - if (netif_running(ndev)) > > - return -EBUSY; > > + if (!netif_running(ndev)) { > > + ndev->mtu = new_mtu; > > + netdev_update_features(ndev); > > + return 0; > > + } > > > > + ravb_close(ndev); > > ndev->mtu = new_mtu; > > - netdev_update_features(ndev); > > > > - return 0; > > + return ravb_open(ndev); > > How about the code below instead? > > if (netif_running(ndev)) > ravb_close(ndev); > > ndev->mtu = new_mtu; > netdev_update_features(ndev); Is there a need to call netdev_update_features() even if the if is not running? > > if (netif_running(ndev)) > return ravb_open(ndev); > > return 0; > > [...] > > MBR, Sergei -- Regards, Niklas Söderlund