Netdev List
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: petkan@nucleusys.com, netdev@vger.kernel.org
Cc: Oliver Neukum <oneukum@suse.com>
Subject: [PATCH] rtl8150: switch to BIT macro
Date: Thu,  9 May 2019 11:01:06 +0200	[thread overview]
Message-ID: <20190509090106.9065-1-oneukum@suse.com> (raw)

A bit of housekeeping switching the driver to the BIT()
macro.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/net/usb/rtl8150.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 59dbdbb5feff..1ed85fba1a7c 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -41,7 +41,7 @@
 #define	ANLP			0x0146
 #define	AER			0x0148
 #define CSCR			0x014C  /* This one has the link status */
-#define CSCR_LINK_STATUS	(1 << 3)
+#define CSCR_LINK_STATUS	BIT(3)
 
 #define	IDR_EEPROM		0x1202
 
@@ -59,20 +59,20 @@
 
 
 /* Transmit status register errors */
-#define TSR_ECOL		(1<<5)
-#define TSR_LCOL		(1<<4)
-#define TSR_LOSS_CRS		(1<<3)
-#define TSR_JBR			(1<<2)
+#define TSR_ECOL		BIT(5)
+#define TSR_LCOL		BIT(4)
+#define TSR_LOSS_CRS		BIT(3)
+#define TSR_JBR			BIT(2)
 #define TSR_ERRORS		(TSR_ECOL | TSR_LCOL | TSR_LOSS_CRS | TSR_JBR)
 /* Receive status register errors */
-#define RSR_CRC			(1<<2)
-#define RSR_FAE			(1<<1)
+#define RSR_CRC			BIT(2)
+#define RSR_FAE			BIT(1)
 #define RSR_ERRORS		(RSR_CRC | RSR_FAE)
 
 /* Media status register definitions */
-#define MSR_DUPLEX		(1<<4)
-#define MSR_SPEED		(1<<3)
-#define MSR_LINK		(1<<2)
+#define MSR_DUPLEX		BIT(4)
+#define MSR_SPEED		BIT(3)
+#define MSR_LINK		BIT(2)
 
 /* Interrupt pipe data */
 #define INT_TSR			0x00
-- 
2.16.4


             reply	other threads:[~2019-05-09  9:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  9:01 Oliver Neukum [this message]
2019-05-09 14:34 ` [PATCH] rtl8150: switch to BIT macro Petko Manolov
2019-05-09 16:49   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190509090106.9065-1-oneukum@suse.com \
    --to=oneukum@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=petkan@nucleusys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox