From: Richard Cochran <richardcochran@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Miroslav Lichvar <mlichvar@redhat.com>,
Jiri Benc <jbenc@redhat.com>, Michal Kubecek <mkubecek@suse.cz>,
David Miller <davem@davemloft.net>,
stefan.sorensen@spectralink.com
Subject: Re: [PATCH net] vlan: disable SIOCSHWTSTAMP in container
Date: Thu, 9 May 2019 06:52:31 -0700 [thread overview]
Message-ID: <20190509135231.ivchey4lwpk6emte@localhost> (raw)
In-Reply-To: <20190509065507.23991-1-liuhangbin@gmail.com>
On Thu, May 09, 2019 at 02:55:07PM +0800, Hangbin Liu wrote:
> With NET_ADMIN enabled in container, a normal user could be mapped to
> root and is able to change the real device's rx filter via ioctl on
> vlan, which would affect the other ptp process on host. Fix it by
> disabling SIOCSHWTSTAMP in container.
>
> Fixes: a6111d3c93d0 ("vlan: Pass SIOC[SG]HWTSTAMP ioctls to real device")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2019-05-09 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 6:55 [PATCH net] vlan: disable SIOCSHWTSTAMP in container Hangbin Liu
2019-05-09 13:52 ` Richard Cochran [this message]
2019-05-09 16:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509135231.ivchey4lwpk6emte@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=mkubecek@suse.cz \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).