From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FD2C04A6B for ; Fri, 10 May 2019 11:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B7C2217D6 for ; Fri, 10 May 2019 11:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfEJL14 (ORCPT ); Fri, 10 May 2019 07:27:56 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:40044 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfEJL14 (ORCPT ); Fri, 10 May 2019 07:27:56 -0400 Received: from cpe-2606-a000-111b-405a-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:405a::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hP3gn-0004bW-QQ; Fri, 10 May 2019 07:27:51 -0400 Date: Fri, 10 May 2019 07:27:18 -0400 From: Neil Horman To: David Miller Cc: lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com Subject: Re: [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT_ACK Message-ID: <20190510112718.GA4902@hmswarspite.think-freely.org> References: <20190509113235.GA12387@hmswarspite.think-freely.org> <20190509.093913.1261211226773919507.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190509.093913.1261211226773919507.davem@davemloft.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 09, 2019 at 09:39:13AM -0700, David Miller wrote: > From: Neil Horman > Date: Thu, 9 May 2019 07:32:35 -0400 > > > This is definately a valid cleanup, but I wonder if it wouldn't be better to, > > instead of removing it, to use it. We have 2 locations where we actually call > > sctp_make_init_ack, and then have to check the return code and abort the > > operation if we get a NULL return. Would it be a better solution (in the sense > > of keeping our control flow in line with how the rest of the state machine is > > supposed to work), if we didn't just add a SCTP_CMD_GEN_INIT_ACK sideeffect to > > the state machine queue in the locations where we otherwise would call > > sctp_make_init_ack/sctp_add_cmd_sf(...SCTP_CMD_REPLY)? > > Also, net-next is closed 8-) > Details, details :)