From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: dsa: Remove dangerous DSA_SKB_CLONE() macro
Date: Sun, 12 May 2019 04:39:01 +0200 [thread overview]
Message-ID: <20190512023901.GL4889@lunn.ch> (raw)
In-Reply-To: <20190511201447.15662-3-olteanv@gmail.com>
On Sat, May 11, 2019 at 11:14:46PM +0300, Vladimir Oltean wrote:
> This does not cause any bug now because it has no users, but its body
> contains two pointer definitions within a code block:
>
> struct sk_buff *clone = _clone; \
> struct sk_buff *skb = _skb; \
>
> When calling the macro as DSA_SKB_CLONE(clone, skb), these variables
> would obscure the arguments that the macro was called with, and the
> initializers would be a no-op instead of doing their job (undefined
> behavior, by the way, but GCC nicely puts NULL pointers instead).
>
> So simply remove this broken macro and leave users to simply call
> "DSA_SKB_CB(skb)->clone = clone" by hand when needed.
>
> There is one functional difference when doing what I just suggested
> above: the control block won't be transferred from the original skb into
> the clone. Since there's no foreseen need for the control block in the
> clone ATM, this is ok.
>
> Fixes: b68b0dd0fb2d ("net: dsa: Keep private info in the skb->cb")
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
If it has no users, it should not of been merged.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-05-12 2:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 20:14 [PATCH net 0/3] Fix a bug and avoid dangerous usage patterns Vladimir Oltean
2019-05-11 20:14 ` [PATCH net 1/3] net: dsa: Initialize DSA_SKB_CB(skb)->deferred_xmit variable Vladimir Oltean
2019-05-11 20:14 ` [PATCH net 2/3] net: dsa: Remove dangerous DSA_SKB_CLONE() macro Vladimir Oltean
2019-05-12 2:39 ` Andrew Lunn [this message]
2019-05-11 20:14 ` [PATCH net 3/3] net: dsa: Remove the now unused DSA_SKB_CB_COPY() macro Vladimir Oltean
2019-05-12 2:39 ` Andrew Lunn
2019-05-11 20:26 ` [PATCH net 0/3] Fix a bug and avoid dangerous usage patterns Vladimir Oltean
2019-05-12 20:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190512023901.GL4889@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).